NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc95765f

Amit Kapila

committed

Remove unnecessary pstrdup in fetch_table_list.

The result of TextDatumGetCString is already palloc'ed so we don't need toallocate memory for it again. We decide not to backpatch it as theredoesn't seem to be any case where it can create a meaningful leak.Author: Zhijie HouReviewed-by: Daniel GustafssonDiscussion:https://postgr.es/m/229fed2eb8c54c71a96ccb99e516eb12@G08CNEXMBPEKD05.g08.fujitsu.local

1 parentc9a0dc3 commitc95765fCopy full SHA for c95765f

File tree

1 file changed

-1

lines changed

src/backend/commands
- subscriptioncmds.c

1 file changed

-1

lines changed

`‎src/backend/commands/subscriptioncmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1267,7 +1267,7 @@ fetch_table_list(WalReceiverConn wrconn, List publications)`
`1267`	`1267`	`relname=TextDatumGetCString(slot_getattr(slot,2,&isnull));`
`1268`	`1268`	`Assert(!isnull);`
`1269`	`1269`
`1270`		`-rv=makeRangeVar(pstrdup(nspname),pstrdup(relname),-1);`
	`1270`	`+rv=makeRangeVar(nspname,relname,-1);`
`1271`	`1271`	`tablelist=lappend(tablelist,rv);`
`1272`	`1272`
`1273`	`1273`	`ExecClearTuple(slot);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc95765f

File tree

1 file changed

1 file changed

`‎src/backend/commands/subscriptioncmds.c`

0 commit comments