NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc890b48

committed

Free PQresult on error in pg_receivexlog.

The leak is fairly small and rare, but a leak nevertheless.Per Coverity report. Backpatch to 9.2, where pg_receivexlog was added.pg_basebackup shares the code, but it always exits on error, so there isno real leak.

1 parente6df2e1 commitc890b48Copy full SHA for c890b48

File tree

1 file changed

-0

lines changed

src/bin/pg_basebackup
- receivelog.c

1 file changed

-0

lines changed

`‎src/bin/pg_basebackup/receivelog.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -858,6 +858,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,`
`858`	`858`	`if (!close_walfile(basedir,partial_suffix,blockpos))`
`859`	`859`	`{`
`860`	`860`	`/* Error message written in close_walfile() */`
	`861`	`+PQclear(res);`
`861`	`862`	`gotoerror;`
`862`	`863`	`}`
`863`	`864`	`if (PQresultStatus(res)==PGRES_COPY_IN)`
`@@ -867,6 +868,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,`
`867`	`868`	`fprintf(stderr,`
`868`	`869`	`_("%s: could not send copy-end packet: %s"),`
`869`	`870`	`progname,PQerrorMessage(conn));`
	`871`	`+PQclear(res);`
`870`	`872`	`gotoerror;`
`871`	`873`	`}`
`872`	`874`	`res=PQgetResult(conn);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc890b48

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/receivelog.c`

0 commit comments