forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitc79aed4
committed
Restore lost amcheck TOAST test coverage.
Commiteba7753 fixed an amcheck false positive bug involvinginconsistencies in TOAST input state between table and index. A testcase was added that verified that such an inconsistency didn't result ina spurious corruption related error.Test coverage from the test was accidentally lost by commit501e41d,which propagated ALTER TABLE ... SET STORAGE attstorage state toindexes. This broke the test because the test specifically relied onattstorage not being propagated. This artificially forced there to beindex tuples whose datums were equivalent to the datums in the heapwithout the datums actually being bitwise equal.Fix this by updating pg_attribute directly instead. Commit501e41dmade similar changes to a test_decoding TOAST-related test case whichmade the same assumption, but overlooked the amcheck test case.Backpatch: 11-, just like commiteba7753 (and commit501e41d).1 parent3d2376d commitc79aed4
2 files changed
+22
-8
lines changedLines changed: 12 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
155 | 155 |
| |
156 | 156 |
| |
157 | 157 |
| |
158 |
| - | |
159 |
| - | |
160 |
| - | |
161 |
| - | |
162 | 158 |
| |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
163 | 171 |
| |
164 | 172 |
| |
165 | 173 |
| |
|
Lines changed: 10 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
99 | 99 |
| |
100 | 100 |
| |
101 | 101 |
| |
102 |
| - | |
103 |
| - | |
104 |
| - | |
105 |
| - | |
106 | 102 |
| |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
107 | 113 |
| |
108 | 114 |
| |
109 | 115 |
| |
|
0 commit comments
Comments
(0)