NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc77f6f5

committed

Fix cases of discarding result from list API functions

Two cases violated list APIs by throwing away the return value. Whilethe code was technically correct, it relied on internal knowledge ofthe list implementation, and the code wasn't really gaining anythingthat way. It is planned to make this a compiler warning in thefuture, so just fix these cases by assigning the return valueproperly.Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://www.postgresql.org/message-id/flat/e3753562-99cd-b65f-5aca-687dfd1ec2fc@2ndquadrant.com

1 parentec29427 commitc77f6f5Copy full SHA for c77f6f5

File tree

2 files changed

-3

lines changed

src/backend
- commands
  - lockcmds.c
- parser
  - analyze.c

2 files changed

-3

lines changed

`‎src/backend/commands/lockcmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ LockViewRecurse(Oid reloid, LOCKMODE lockmode, bool nowait,`
`266`	`266`
`267`	`267`	`LockViewRecurse_walker((Node*)viewquery,&context);`
`268`	`268`
`269`		`-(void)list_delete_last(context.ancestor_views);`
	`269`	`+context.ancestor_views=list_delete_last(context.ancestor_views);`
`270`	`270`
`271`	`271`	`table_close(view,NoLock);`
`272`	`272`	`}`

`‎src/backend/parser/analyze.c`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1475,8 +1475,7 @@ transformValuesClause(ParseState pstate, SelectStmt stmt)`
`1475`	`1475`	`Nodecol= (Node)lfirst(lc);`
`1476`	`1476`	`List*sublist=lfirst(lc2);`
`1477`	`1477`
`1478`		`-/* sublist pointer in exprsLists won't need adjustment */`
`1479`		`-(void)lappend(sublist,col);`
	`1478`	`+sublist=lappend(sublist,col);`
`1480`	`1479`	`}`
`1481`	`1480`	`list_free(colexprs[i]);`
`1482`	`1481`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc77f6f5

File tree

2 files changed

2 files changed

`‎src/backend/commands/lockcmds.c`

`‎src/backend/parser/analyze.c`

0 commit comments