NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc702d65

committed

heap pruning: Only call BufferGetBlockNumber() once.

BufferGetBlockNumber() is not that cheap and obviously cannot change duringone heap_prune_page(), so only call it once. We might be able to do better andpass the block number from the caller, but that'd be a larger change...Discussion:https://postgr.es/m/20211211045710.ljtuu4gfloh754rs@alap3.anarazel.de

1 parent35b2803 commitc702d65Copy full SHA for c702d65

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- pruneheap.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/pruneheap.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,7 @@ heap_page_prune(Relation relation, Buffer buffer,`
`269`	`269`	`{`
`270`	`270`	`intndeleted=0;`
`271`	`271`	`Pagepage=BufferGetPage(buffer);`
	`272`	`+BlockNumberblockno=BufferGetBlockNumber(buffer);`
`272`	`273`	`OffsetNumberoffnum,`
`273`	`274`	`maxoff;`
`274`	`275`	`PruneStateprstate;`
`@@ -335,7 +336,7 @@ heap_page_prune(Relation relation, Buffer buffer,`
`335`	`336`	`htup= (HeapTupleHeader)PageGetItem(page,itemid);`
`336`	`337`	`tup.t_data=htup;`
`337`	`338`	`tup.t_len=ItemIdGetLength(itemid);`
`338`		`-ItemPointerSet(&(tup.t_self),BufferGetBlockNumber(buffer),offnum);`
	`339`	`+ItemPointerSet(&(tup.t_self),blockno,offnum);`
`339`	`340`
`340`	`341`	`/*`
`341`	`342`	`* Set the offset number so that we can display it along with any`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc702d65

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/pruneheap.c`

0 commit comments