NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc6ec879

committed

Don't abort pg_basebackup when receiving empty WAL block

This can happen exactly at the switch of a logical WAL file(segment number ending in FE), when running pg_basebackup connectedto a standby server, and would cause the backup to abort withthe error message "streaming header too small".There is nothing wrong with an empty message, it's just unnecessary,and the rest of the code can handle the case of an empty message,so this patch just removes the error condition when the size isexactly zero.

1 parent9a45a65 commitc6ec879Copy full SHA for c6ec879

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- receivelog.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/receivelog.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -495,7 +495,7 @@ ReceiveXlogStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,`
`495`	`495`	`progname,copybuf[0]);`
`496`	`496`	`gotoerror;`
`497`	`497`	`}`
`498`		`-if (r<STREAMING_HEADER_SIZE+1)`
	`498`	`+if (r<STREAMING_HEADER_SIZE)`
`499`	`499`	`{`
`500`	`500`	`fprintf(stderr,_("%s: streaming header too small: %d\n"),`
`501`	`501`	`progname,r);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc6ec879

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/receivelog.c‎`

0 commit comments