Commitc62a0a4

committed

Revert "Make vacuum a bit more verbose to debug BF failure."

This reverts commit49967da.Enough time has passed that we can be confident that07f32fcresolved the issue. Therefore we can remove the temporary debuggingaids.Author: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/E1k7tGP-0005V0-5k@gemulon.postgresql.org

1 parent0784c33 commitc62a0a4Copy full SHA for c62a0a4

File tree

-17

lines changed

-17

lines changed

Lines changed: 1 addition & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -6048,16 +6048,7 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,`
`6048`	`6048`	`TransactionIdIsInProgress(members[i].xid))`
`6049`	`6049`	`{`
`6050`	`6050`	`/* running locker cannot possibly be older than the cutoff */`
`6051`		`-if (TransactionIdPrecedes(members[i].xid,cutoff_xid))`
`6052`		`-{`
`6053`		`-/* temporary on-bf debugging */`
`6054`		`-elog(PANIC,"too old alive locker: multi: %u, member xid: %u, memb-current: %d, memb-progress: %d, cutoff: %u, cutoff-multi: %u, relfrozenxid: %u, relminmxid: %u",`
`6055`		`-multi,members[i].xid,`
`6056`		`-TransactionIdIsCurrentTransactionId(members[i].xid),`
`6057`		`-TransactionIdIsInProgress(members[i].xid),`
`6058`		`-cutoff_xid,cutoff_multi,`
`6059`		`-relfrozenxid,relminmxid);`
`6060`		`-}`
	`6051`	`+Assert(!TransactionIdPrecedes(members[i].xid,cutoff_xid));`
`6061`	`6052`	`newmembers[nnewmembers++]=members[i];`
`6062`	`6053`	`has_lockers= true;`
`6063`	`6054`	`}`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1350,14 +1350,7 @@ lazy_scan_heap(Relation onerel, VacuumParams params, LVRelStats vacrelstats,`
`1350`	`1350`	`if (HeapTupleIsHotUpdated(&tuple)\|\|`
`1351`	`1351`	`HeapTupleIsHeapOnly(&tuple)\|\|`
`1352`	`1352`	`params->index_cleanup==VACOPT_TERNARY_DISABLED)`
`1353`		`-{`
`1354`		`-/* temporary on-bf debugging */`
`1355`		`-elog(LOG,"treating dead HOT tuple (updated %d, heap only: %d, index cleanup: %d) as alive",`
`1356`		`-HeapTupleIsHotUpdated(&tuple),HeapTupleIsHeapOnly(&tuple),`
`1357`		`-params->index_cleanup==VACOPT_TERNARY_DISABLED);`
`1358`		`-`
`1359`	`1353`	`nkeep+=1;`
`1360`		`-}`
`1361`	`1354`	`else`
`1362`	`1355`	`tupgone= true;/* we can delete the tuple */`
`1363`	`1356`	`all_visible= false;`

Comments

(0)