Commitc5f4406

alvherre

authored and

pull[bot]

committed

Fix perltidy breaking perlcritic

perltidying a "##no critic" line moves the marker to where it becomesuseless. Put the line back to how it was, and protect it from furthermalfeasance.Per buildfarm member crake.

1 parent6620f93 commitc5f4406Copy full SHA for c5f4406

File tree

1 file changed

-2

lines changed

src/backend/catalog
- Catalog.pm

1 file changed

-2

lines changed

`‎src/backend/catalog/Catalog.pm`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -315,8 +315,10 @@ sub ParseData`
`315`	`315`	`# We're treating the input line as a piece of Perl, so we`
`316`	`316`	`# need to use string eval here. Tell perlcritic we know what`
`317`	`317`	`# we're doing.`
`318`		`-eval'$hash_ref ='`
`319`		`- .$_;## no critic (ProhibitStringyEval)`
	`318`	`+#<<< protect next line from perltidy`
	`319`	`+# so perlcritic annotation works`
	`320`	`+eval'$hash_ref =' .$_;## no critic (ProhibitStringyEval)`
	`321`	`+#>>>`
`320`	`322`	`if (!ref$hash_ref)`
`321`	`323`	`{`
`322`	`324`	`die"$input_file: error parsing line$.:\n$_\n";`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc5f4406

File tree

1 file changed

1 file changed

`‎src/backend/catalog/Catalog.pm`

0 commit comments