Commitc5e073c

committed

ecpg: Fix off-by-one error in memory copying

In a rare case, one byte past the end of memory belonging to thesqlca_t structure would be written to.found by Coverity

1 parent8dd4d10 commitc5e073cCopy full SHA for c5e073c

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,7 @@ ECPGset_var(int number, void *pointer, int lineno)`
`525`	`525`	`structsqlca_t*sqlca=ECPGget_sqlca();`
`526`	`526`
`527`	`527`	`sqlca->sqlcode=ECPG_OUT_OF_MEMORY;`
`528`		`-strncpy(sqlca->sqlstate,"YE001",sizeof("YE001"));`
	`528`	`+strncpy(sqlca->sqlstate,"YE001",sizeof(sqlca->sqlstate));`
`529`	`529`	`snprintf(sqlca->sqlerrm.sqlerrmc,sizeof(sqlca->sqlerrm.sqlerrmc),"out of memory on line %d",lineno);`
`530`	`530`	`sqlca->sqlerrm.sqlerrml=strlen(sqlca->sqlerrm.sqlerrmc);`
`531`	`531`	`/* free all memory we have allocated for the user */`

Comments

(0)