NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc5c1cc3

committed

This patch will ensure that the hash table iteration performed by

AtCommit_Portals is restarted when a portal is deleted. This isnecessary since the deletion of a portal may cause the deletion ofanother which on rare occations may cause the iterator to return adeleted portal an thus a renewed attempt delete.Thomas Hallgren

1 parentbe1cc69 commitc5c1cc3Copy full SHA for c5c1cc3

File tree

1 file changed

-7

lines changed

src/backend/utils/mmgr
- portalmem.c

1 file changed

-7

lines changed

`‎src/backend/utils/mmgr/portalmem.c`

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`* Portions Copyright (c) 1994, Regents of the University of California`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $PostgreSQL: pgsql/src/backend/utils/mmgr/portalmem.c,v 1.78 2005/04/1119:51:15 tgl Exp $`
	`15`	`+ * $PostgreSQL: pgsql/src/backend/utils/mmgr/portalmem.c,v 1.79 2005/05/1118:05:37 momjian Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -475,12 +475,6 @@ CommitHoldablePortals(void)`
`475`	`475`	`*`
`476`	`476`	`* Remove all non-holdable portals created in this transaction.`
`477`	`477`	`* Portals remaining from prior transactions should be left untouched.`
`478`		`- *`
`479`		`- * XXX This assumes that portals can be deleted in a random order, ie,`
`480`		`- * no portal has a reference to any other (at least not one that will be`
`481`		`- * exercised during deletion).I think this is okay at the moment, but`
`482`		`- * we've had bugs of that ilk in the past. Keep a close eye on cursor`
`483`		`- * references...`
`484`	`478`	`*/`
`485`	`479`	`void`
`486`	`480`	`AtCommit_Portals(void)`
`@@ -516,6 +510,9 @@ AtCommit_Portals(void)`
`516`	`510`
`517`	`511`	`/* Zap all non-holdable portals */`
`518`	`512`	`PortalDrop(portal, true);`
	`513`	`+`
	`514`	`+/* Restart the iteration */`
	`515`	`+hash_seq_init(&status,PortalHashTable);`
`519`	`516`	`}`
`520`	`517`	`}`
`521`	`518`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc5c1cc3

File tree

1 file changed

1 file changed

`‎src/backend/utils/mmgr/portalmem.c`

0 commit comments