NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc5be48f

Amit Kapila

committed

Improve FK trigger parallel-safety check added by05c8482.

Commit05c8482 added special logic related to parallel-safety of FKtriggers. This is a bit of a hack and should have instead been done bysimply setting appropriate proparallel values on those trigger functionsthemselves.Suggested-by: Tom LaneAuthor: Greg NancarrowReviewed-by: Amit KapilaDiscussion:https://postgr.es/m/2309260.1615485644@sss.pgh.pa.us

1 parentb9164ea commitc5be48fCopy full SHA for c5be48f

File tree

3 files changed

-19

lines changed

src
- backend/optimizer/util
  - clauses.c
- include/catalog
  - catversion.h
  - pg_proc.dat

3 files changed

-19

lines changed

`‎src/backend/optimizer/util/clauses.c`

Lines changed: 0 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -971,24 +971,10 @@ target_rel_trigger_max_parallel_hazard(Relation rel,`
`971`	`971`	`*/`
`972`	`972`	`for (i=0;i<rel->trigdesc->numtriggers;i++)`
`973`	`973`	`{`
`974`		`-inttrigtype;`
`975`	`974`	`Oidtgfoid=rel->trigdesc->triggers[i].tgfoid;`
`976`	`975`
`977`	`976`	`if (max_parallel_hazard_test(func_parallel(tgfoid),context))`
`978`	`977`	`return true;`
`979`		`-`
`980`		`-/*`
`981`		`- * If the trigger type is RI_TRIGGER_FK, this indicates a FK exists in`
`982`		`- * the relation, and this would result in creation of new CommandIds`
`983`		`- * on insert/update and this isn't supported in a parallel worker (but`
`984`		`- * is safe in the parallel leader).`
`985`		`- */`
`986`		`-trigtype=RI_FKey_trigger_type(tgfoid);`
`987`		`-if (trigtype==RI_TRIGGER_FK)`
`988`		`-{`
`989`		`-if (max_parallel_hazard_test(PROPARALLEL_RESTRICTED,context))`
`990`		`-return true;`
`991`		`-}`
`992`	`978`	`}`
`993`	`979`
`994`	`980`	`return false;`

`‎src/include/catalog/catversion.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,6 @@`
`53`	`53`	`*/`
`54`	`54`
`55`	`55`	`/yyyymmddN /`
`56`		`-#defineCATALOG_VERSION_NO202103093`
	`56`	`+#defineCATALOG_VERSION_NO202103131`
`57`	`57`
`58`	`58`	`#endif`

`‎src/include/catalog/pg_proc.dat`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -3745,11 +3745,11 @@`
`3745`	`3745`
`3746`	`3746`	`# Generic referential integrity constraint triggers`
`3747`	`3747`	`{ oid => '1644', descr => 'referential integrity FOREIGN KEY ... REFERENCES',`
`3748`		`- proname => 'RI_FKey_check_ins', provolatile => 'v',prorettype => 'trigger',`
`3749`		`- proargtypes => '', prosrc => 'RI_FKey_check_ins' },`
	`3748`	`+ proname => 'RI_FKey_check_ins', provolatile => 'v',proparallel => 'r',`
	`3749`	`+prorettype => 'trigger',proargtypes => '', prosrc => 'RI_FKey_check_ins' },`
`3750`	`3750`	`{ oid => '1645', descr => 'referential integrity FOREIGN KEY ... REFERENCES',`
`3751`		`- proname => 'RI_FKey_check_upd', provolatile => 'v',prorettype => 'trigger',`
`3752`		`- proargtypes => '', prosrc => 'RI_FKey_check_upd' },`
	`3751`	`+ proname => 'RI_FKey_check_upd', provolatile => 'v',proparallel => 'r',`
	`3752`	`+prorettype => 'trigger',proargtypes => '', prosrc => 'RI_FKey_check_upd' },`
`3753`	`3753`	`{ oid => '1646', descr => 'referential integrity ON DELETE CASCADE',`
`3754`	`3754`	`proname => 'RI_FKey_cascade_del', provolatile => 'v', prorettype => 'trigger',`
`3755`	`3755`	`proargtypes => '', prosrc => 'RI_FKey_cascade_del' },`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc5be48f

File tree

3 files changed

3 files changed

`‎src/backend/optimizer/util/clauses.c`

`‎src/include/catalog/catversion.h`

`‎src/include/catalog/pg_proc.dat`

0 commit comments