NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc545e95

committed

Don't prematurely cram a value into a short int.

Sincea4d75c8, some buildfarm members have been warning thatAssert(attnum <= MaxAttrNumber);is useless if attnum is an AttrNumber. I'm not certain how plausibleit is that the value coming out of the bitmap could actually exceedMaxAttrNumber, but we seem to have thought that that was possible backin7300a69. Revert the intermediate variable to int so that we havethe same overflow protection as before.

1 parent3b0c647 commitc545e95Copy full SHA for c545e95

File tree

1 file changed

-1

lines changed

src/backend/statistics
- extended_stats.c

1 file changed

-1

lines changed

`‎src/backend/statistics/extended_stats.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -978,7 +978,7 @@ build_attnums_array(Bitmapset attrs, int nexprs, int numattrs)`
`978`	`978`	`j=-1;`
`979`	`979`	`while ((j=bms_next_member(attrs,j)) >=0)`
`980`	`980`	`{`
`981`		`-AttrNumberattnum= (j-nexprs);`
	`981`	`+intattnum= (j-nexprs);`
`982`	`982`
`983`	`983`	`/*`
`984`	`984`	`* Make sure the bitmap contains only user-defined attributes. As`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc545e95

File tree

1 file changed

1 file changed

`‎src/backend/statistics/extended_stats.c`

0 commit comments