NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc52ad9c

committed

Fix assert in logicalmsg_desc

The assert, introduced by9f1cf97, is intended to check if the prefixis terminated by a \0 byte, but it has two flaws. Firstly, prefix_sizeincludes the \0 byte, so prefix[prefix_size] points to the byte afterthe null byte. Secondly, the check ensures the byte is not equal \0,while it should be checking the opposite.Backpatch-through: 14Discussion:https://postgr.es/m/b99b6101-2f14-3796-3dfa-4a6cd7d4326d@enterprisedb.com

1 parent40ca907 commitc52ad9cCopy full SHA for c52ad9c

File tree

1 file changed

-1

lines changed

src/backend/access/rmgrdesc
- logicalmsgdesc.c

1 file changed

-1

lines changed

`‎src/backend/access/rmgrdesc/logicalmsgdesc.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ logicalmsg_desc(StringInfo buf, XLogReaderState *record)`
`28`	`28`	`char*message=xlrec->message+xlrec->prefix_size;`
`29`	`29`	`char*sep="";`
`30`	`30`
`31`		`-Assert(prefix[xlrec->prefix_size]!='\0');`
	`31`	`+Assert(prefix[xlrec->prefix_size-1]=='\0');`
`32`	`32`
`33`	`33`	`appendStringInfo(buf,"%s, prefix \"%s\"; payload (%zu bytes): ",`
`34`	`34`	`xlrec->transactional ?"transactional" :"non-transactional",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc52ad9c

File tree

1 file changed

1 file changed

`‎src/backend/access/rmgrdesc/logicalmsgdesc.c`

0 commit comments