NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc5111ea

committed

Remove no-longer-needed phony typedefs in genbki.h.

Now that we have a policy of hiding varlena catalog fields behind"#ifdef CATALOG_VARLEN", there is no need for their type names to beacceptable to the C compiler. And experimentation shows that it doesnot matter to pgindent either. (If it did, we'd have problems anyway,since these typedefs are unreferenced so far as the C compiler isconcerned, and find_typedef fails to identify such typedefs.)Hence, remove the phony typedefs that genbki.h provided to makesome varlena field definitions compilable.In passing, rearrange #define's into what seemed a more logical order.

1 parentf9e0255 commitc5111eaCopy full SHA for c5111ea

File tree

1 file changed

-11

lines changed

src/include/catalog
- genbki.h

1 file changed

-11

lines changed

`‎src/include/catalog/genbki.h`

Lines changed: 7 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,13 @@`
`22`	`22`	`/* Introduces a catalog's structure definition */`
`23`	`23`	`#defineCATALOG(name,oid)typedef struct CppConcat(FormData_,name)`
`24`	`24`
	`25`	`+/* Options that may appear after CATALOG (on the same line) */`
	`26`	`+#defineBKI_BOOTSTRAP`
	`27`	`+#defineBKI_SHARED_RELATION`
	`28`	`+#defineBKI_WITHOUT_OIDS`
	`29`	`+#defineBKI_ROWTYPE_OID(oid)`
	`30`	`+#defineBKI_SCHEMA_MACRO`
	`31`	`+`
`25`	`32`	`/*`
`26`	`33`	`* This is never defined; it's here only for documentation.`
`27`	`34`	`*`
`@@ -32,21 +39,10 @@`
`32`	`39`	`*/`
`33`	`40`	`#undef CATALOG_VARLEN`
`34`	`41`
`35`		`-/* Options that may appear after CATALOG (on the same line) */`
`36`		`-#defineBKI_BOOTSTRAP`
`37`		`-#defineBKI_SHARED_RELATION`
`38`		`-#defineBKI_WITHOUT_OIDS`
`39`		`-#defineBKI_ROWTYPE_OID(oid)`
`40`		`-#defineBKI_SCHEMA_MACRO`
`41`		`-`
`42`	`42`	`/* Declarations that provide the initial content of a catalog */`
`43`	`43`	`/* In C, these need to expand into some harmless, repeatable declaration */`
`44`	`44`	`#defineDATA(x) extern int no_such_variable`
`45`	`45`	`#defineDESCR(x) extern int no_such_variable`
`46`	`46`	`#defineSHDESCR(x) extern int no_such_variable`
`47`	`47`
`48`		`-/* PHONY type definitions for use in catalog structure definitions only */`
`49`		`-typedefintaclitem;`
`50`		`-typedefintpg_node_tree;`
`51`		`-`
`52`	`48`	`#endif/* GENBKI_H */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc5111ea

File tree

1 file changed

1 file changed

`‎src/include/catalog/genbki.h`

0 commit comments