Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc4c9c77

Browse files
committed
Cleanup some code related to pgbench log checks in TAP tests
This fixes a couple of problems within the so-said code of this commitsubject:- Replace the use of open() with slurp_file(), fixing an issue reportedby buildfarm member fairywren whose perl installation keep around CRLFcharacters, causing the matching patterns for the logs to fail.- Remove the eval block, which is not really necessary.This set of issues has come into light after fixing a different issuewithc13585f, and this is wrong since this code has been introduced.Reported-by: Andrew Dunstan, and buildfarm member fairywrenAuthor: Michael PaquierReviewed-by: Andrew DunstanDiscussion:https://postgr.es/m/0f49303e-7784-b3ee-200b-cbf67be2eb9e@dunslane.netBackpatch-through: 11
1 parent6ada4fd commitc4c9c77

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

‎src/bin/pgbench/t/001_pgbench_with_server.pl

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -834,18 +834,27 @@ sub check_pgbench_logs
834834
my$log_number = 0;
835835
formy$log (sort@logs)
836836
{
837-
eval {
838-
openmy$fh,'<',$logordie"$@";
839-
my@contents = <$fh>;
840-
my$clen =@contents;
841-
ok($min <=$clen &&$clen <=$max,
842-
"transaction count for$log ($clen)");
843-
ok(grep(/$re/,@contents) ==$clen,
844-
"transaction format for$prefix");
845-
close$fhordie"$@";
846-
};
837+
# Check the contents of each log file.
838+
my$contents_raw = slurp_file($log);
839+
840+
my@contents =split(/\n/,$contents_raw);
841+
my$clen =@contents;
842+
ok($min <=$clen &&$clen <=$max,
843+
"transaction count for$log ($clen)");
844+
my$clen_match =grep(/$re/,@contents);
845+
ok($clen_match ==$clen,"transaction format for$prefix");
846+
847+
# Show more information if some logs don't match
848+
# to help with debugging.
849+
if ($clen_match !=$clen)
850+
{
851+
foreachmy$log (@contents)
852+
{
853+
print"# Log entry not matching:$log\n"
854+
unless$log =~/$re/;
855+
}
856+
}
847857
}
848-
ok(unlink(@logs),"remove log files");
849858
return;
850859
}
851860

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp