forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitc484134
committed
Clean up duplicate role and schema names in regression tests.
Since these names are global, using the same ones in different regressiontests creates a hazard of test failures if any two such scripts runconcurrently. Let's establish a policy of not doing that. In the caseswhere a conflict existed, I chose to rename both sides: in principle onescript or the other could've been left in possession of the common name,but that seems to just invite more trouble of the same sort.There are a number of places where scripts are using names that seemunduly generic, but in the absence of actual conflicts I left them alone.In addition, fix insert.sql's use of "someone_else" as a role name.That's a flat out violation of longstanding project policy, so back-patchthat change to v10 where the usage appeared. The rest of this is justfuture-proofing, as no two of these scripts are actually run concurrentlyin the existing parallel_schedule.Conflicts of schema-qualified names also exist, but will be dealt withseparately.Discussion:https://postgr.es/m/4627.1521070268@sss.pgh.pa.us1 parenta2102e1 commitc484134
2 files changed
+18
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
429 | 429 | | |
430 | 430 | | |
431 | 431 | | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
440 | | - | |
441 | | - | |
| 440 | + | |
| 441 | + | |
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
| |||
447 | 447 | | |
448 | 448 | | |
449 | 449 | | |
450 | | - | |
451 | | - | |
452 | | - | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
453 | 453 | | |
454 | 454 | | |
455 | 455 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
283 | | - | |
284 | | - | |
285 | | - | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
286 | 286 | | |
287 | | - | |
| 287 | + | |
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
291 | 291 | | |
292 | | - | |
293 | | - | |
| 292 | + | |
| 293 | + | |
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
300 | | - | |
301 | | - | |
302 | | - | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
| |||
0 commit comments
Comments
(0)