forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitc410af0
committed
Mop up some no-longer-necessary hacks around printf %.*s format.
Commit54cd4f0 added some kluges to work around an old glibc bug,namely that %.*s could misbehave if glibc thought any characters inthe supplied string were incorrectly encoded. Now that we use ourown snprintf.c implementation, we need not worry about that bug (evenif it still exists in the wild). Revert a couple of particularlyugly hacks, and remove or improve assorted comments.Note that there can still be encoding-related hazards here: blindlyclipping at a fixed length risks producing wrongly-encoded outputif the clip splits a multibyte character. However, code that'sdoing correct multibyte-aware clipping doesn't really need a commentabout that, while code that isn't needs an explanation why not,rather than a red-herring comment about an obsolete bug.Discussion:https://postgr.es/m/279428.1593373684@sss.pgh.pa.us1 parentf7a476f commitc410af0
File tree
9 files changed
+16
-75
lines changed- src
- backend
- commands
- parser
- tsearch
- utils/adt
- fe_utils
- interfaces
- ecpg
- ecpglib
- pgtypeslib
- libpq
9 files changed
+16
-75
lines changedLines changed: 1 addition & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2303 | 2303 |
| |
2304 | 2304 |
| |
2305 | 2305 |
| |
2306 |
| - | |
2307 |
| - | |
2308 |
| - | |
2309 |
| - | |
2310 |
| - | |
| 2306 | + | |
2311 | 2307 |
| |
2312 | 2308 |
| |
2313 | 2309 |
| |
|
Lines changed: 2 additions & 12 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
189 | 189 |
| |
190 | 190 |
| |
191 | 191 |
| |
192 |
| - | |
193 |
| - | |
194 |
| - | |
195 |
| - | |
196 |
| - | |
197 |
| - | |
198 |
| - | |
199 |
| - | |
200 |
| - | |
201 | 192 |
| |
202 | 193 |
| |
203 |
| - | |
204 |
| - | |
205 |
| - | |
| 194 | + | |
| 195 | + | |
206 | 196 |
| |
207 | 197 |
| |
208 | 198 |
| |
|
Lines changed: 0 additions & 7 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
324 | 324 |
| |
325 | 325 |
| |
326 | 326 |
| |
327 |
| - | |
328 |
| - | |
329 |
| - | |
330 |
| - | |
331 |
| - | |
332 |
| - | |
333 | 327 |
| |
334 | 328 |
| |
335 | 329 |
| |
| |||
366 | 360 |
| |
367 | 361 |
| |
368 | 362 |
| |
369 |
| - | |
370 | 363 |
| |
371 | 364 |
| |
372 | 365 |
| |
|
Lines changed: 2 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4013 | 4013 |
| |
4014 | 4014 |
| |
4015 | 4015 |
| |
4016 |
| - | |
| 4016 | + | |
| 4017 | + | |
4017 | 4018 |
| |
4018 | 4019 |
| |
4019 | 4020 |
| |
|
Lines changed: 0 additions & 10 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3554 | 3554 |
| |
3555 | 3555 |
| |
3556 | 3556 |
| |
3557 |
| - | |
3558 |
| - | |
3559 |
| - | |
3560 |
| - | |
3561 |
| - | |
3562 | 3557 |
| |
3563 | 3558 |
| |
3564 | 3559 |
| |
| |||
4438 | 4433 |
| |
4439 | 4434 |
| |
4440 | 4435 |
| |
4441 |
| - | |
4442 |
| - | |
4443 |
| - | |
4444 |
| - | |
4445 |
| - | |
4446 | 4436 |
| |
4447 | 4437 |
| |
4448 | 4438 |
| |
|
Lines changed: 6 additions & 22 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
305 | 305 |
| |
306 | 306 |
| |
307 | 307 |
| |
308 |
| - | |
309 |
| - | |
310 |
| - | |
311 |
| - | |
312 |
| - | |
313 |
| - | |
314 |
| - | |
315 |
| - | |
316 |
| - | |
317 |
| - | |
318 |
| - | |
319 |
| - | |
320 |
| - | |
321 |
| - | |
322 | 308 |
| |
323 | 309 |
| |
324 | 310 |
| |
| |||
1042 | 1028 |
| |
1043 | 1029 |
| |
1044 | 1030 |
| |
1045 |
| - | |
1046 |
| - | |
1047 |
| - | |
| 1031 | + | |
| 1032 | + | |
1048 | 1033 |
| |
1049 | 1034 |
| |
1050 | 1035 |
| |
1051 | 1036 |
| |
1052 |
| - | |
1053 |
| - | |
1054 |
| - | |
| 1037 | + | |
| 1038 | + | |
1055 | 1039 |
| |
1056 | 1040 |
| |
1057 | 1041 |
| |
| |||
1637 | 1621 |
| |
1638 | 1622 |
| |
1639 | 1623 |
| |
1640 |
| - | |
1641 |
| - | |
| 1624 | + | |
| 1625 | + | |
1642 | 1626 |
| |
1643 | 1627 |
| |
1644 | 1628 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
270 | 270 |
| |
271 | 271 |
| |
272 | 272 |
| |
273 |
| - | |
274 | 273 |
| |
275 | 274 |
| |
276 | 275 |
| |
|
Lines changed: 2 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
826 | 826 |
| |
827 | 827 |
| |
828 | 828 |
| |
829 |
| - | |
| 829 | + | |
| 830 | + | |
830 | 831 |
| |
831 | 832 |
| |
832 | 833 |
| |
|
Lines changed: 3 additions & 16 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
68 | 68 |
| |
69 | 69 |
| |
70 | 70 |
| |
71 |
| - | |
72 |
| - | |
73 |
| - | |
74 |
| - | |
75 |
| - | |
76 |
| - | |
77 |
| - | |
78 |
| - | |
79 |
| - | |
80 |
| - | |
81 |
| - | |
82 |
| - | |
83 |
| - | |
84 | 71 |
| |
85 | 72 |
| |
86 | 73 |
| |
| |||
204 | 191 |
| |
205 | 192 |
| |
206 | 193 |
| |
207 |
| - | |
| 194 | + | |
208 | 195 |
| |
209 | 196 |
| |
210 | 197 |
| |
| |||
228 | 215 |
| |
229 | 216 |
| |
230 | 217 |
| |
231 |
| - | |
| 218 | + | |
232 | 219 |
| |
233 | 220 |
| |
234 | 221 |
| |
| |||
250 | 237 |
| |
251 | 238 |
| |
252 | 239 |
| |
253 |
| - | |
| 240 | + | |
254 | 241 |
| |
255 | 242 |
| |
256 | 243 |
| |
|
0 commit comments
Comments
(0)