NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc341c7d

committed

Fix some compiler warnings with timestamp parsing in formatting.c

gcc-7 used with a sufficient optimization level complains about warningsaround do_to_timestamp() regarding the initialization and handling ofsome of its variables. Recent commits 66c74f8 andd589f94 made thingsmade the interface more confusing, so document which variables arealways expected and initialize properly the optional ones when they areset.Author: Andrey Lepikhov, Michael PaquierDiscussion:https://postgr.es/m/a7e28b83-27b1-4e1c-c76b-4268c4b785bc@postgrespro.ru

1 parent8729fa7 commitc341c7dCopy full SHA for c341c7d

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- formatting.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/formatting.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4128,7 +4128,7 @@ parse_datetime(text date_txt, text fmt, bool strict, Oid *typid,`
`4128`	`4128`	`{`
`4129`	`4129`	`structpg_tmtm;`
`4130`	`4130`	`fsec_tfsec;`
`4131`		`-intfprec=0;`
	`4131`	`+intfprec;`
`4132`	`4132`	`uint32flags;`
`4133`	`4133`
`4134`	`4134`	`do_to_timestamp(date_txt,fmt,strict,&tm,&fsec,&fprec,&flags,have_error);`
`@@ -4318,11 +4318,18 @@ do_to_timestamp(text date_txt, text fmt, bool std,`
`4318`	`4318`	`intfmask;`
`4319`	`4319`	`boolincache= false;`
`4320`	`4320`
	`4321`	`+Assert(tm!=NULL);`
	`4322`	`+Assert(fsec!=NULL);`
	`4323`	`+`
`4321`	`4324`	`date_str=text_to_cstring(date_txt);`
`4322`	`4325`
`4323`	`4326`	`ZERO_tmfc(&tmfc);`
`4324`	`4327`	`ZERO_tm(tm);`
`4325`	`4328`	`*fsec=0;`
	`4329`	`+if (fprec)`
	`4330`	`+*fprec=0;`
	`4331`	`+if (flags)`
	`4332`	`+*flags=0;`
`4326`	`4333`	`fmask=0;/* bit mask for ValidateDate() */`
`4327`	`4334`
`4328`	`4335`	`fmt_len=VARSIZE_ANY_EXHDR(fmt);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc341c7d

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/formatting.c`

0 commit comments