NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc3333db

committed

Only perform pg_strong_random init when required

The random number generator in OpenSSL 1.1.1 was redesigned to providefork safety by default, thus removing the need for calling RAND_pollafter forking to ensure that two processes cannot share the same state.Since we now support 1.1.0 as the minumum version, and 1.1.0 is beingincreasingly phased out from production use, only perform the RAND_pollinitialization for installations running 1.1.0 by checking the OpenSSLversion number.LibreSSL changed random number generator when forking OpenSSL and hasprovided fork safety since version 2.0.2.This removes the overhead of initializing the RNG for strong randomfor the vast majority of users for whom it is no longer required.Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>Reviewed-by: Peter Eisentraut <peter@eisentraut.org>Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/CA+hUKGKh7QrYzu=8yWEUJvXtMVm_CNWH1L_TLWCbZMwbi1XP2Q@mail.gmail.com

1 parenta70e01d commitc3333dbCopy full SHA for c3333db

File tree

1 file changed

-3

lines changed

src/port
- pg_strong_random.c

1 file changed

-3

lines changed

`‎src/port/pg_strong_random.c`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,17 +50,20 @@`
`50`	`50`
`51`	`51`	`#ifdefUSE_OPENSSL`
`52`	`52`
	`53`	`+#include<openssl/opensslv.h>`
`53`	`54`	`#include<openssl/rand.h>`
`54`	`55`
`55`	`56`	`void`
`56`	`57`	`pg_strong_random_init(void)`
`57`	`58`	`{`
	`59`	`+#if (OPENSSL_VERSION_NUMBER<0x10101000L)`
`58`	`60`	`/*`
`59`		`- * Make sure processes do not share OpenSSL randomness state. This isno`
`60`		`- * longer required in OpenSSL 1.1.1 and later versions, but until we drop`
`61`		`- *support for version < 1.1.1 we need to do this.`
	`61`	`+ * Make sure processes do not share OpenSSL randomness state. This isnot`
	`62`	`+ *required on LibreSSL and nolonger required in OpenSSL 1.1.1 and later`
	`63`	`+ *versions.`
`62`	`64`	`*/`
`63`	`65`	`RAND_poll();`
	`66`	`+#endif`
`64`	`67`	`}`
`65`	`68`
`66`	`69`	`bool`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc3333db

File tree

1 file changed

1 file changed

`‎src/port/pg_strong_random.c`

0 commit comments