Commitc31e9d4

committed

Improve error message when skipping scan of default partition.

It seems like a good idea to clearly distinguish between skipping thescan of the new partition itself and skipping the scan of the defaultpartition.Amit LangoteDiscussion:http://postgr.es/m/1f08b844-0078-aa8d-452e-7af3bf77d05f@lab.ntt.co.jp

1 parente9baa5e commitc31e9d4Copy full SHA for c31e9d4

File tree

+10

-5

lines changed

src
- backend/commands
  - tablecmds.c
- test/regress/expected
  - alter_table.out

+10

-5

lines changed

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -13635,9 +13635,14 @@ ValidatePartitionConstraints(List **wqueue, Relation scanrel,`
`13635`	`13635`	`*/`
`13636`	`13636`	`if (PartConstraintImpliedByRelConstraint(scanrel,partConstraint))`
`13637`	`13637`	`{`
`13638`		`-ereport(INFO,`
`13639`		`-(errmsg("partition constraint for table \"%s\" is implied by existing constraints",`
`13640`		`-RelationGetRelationName(scanrel))));`
	`13638`	`+if (!validate_default)`
	`13639`	`+ereport(INFO,`
	`13640`	`+(errmsg("partition constraint for table \"%s\" is implied by existing constraints",`
	`13641`	`+RelationGetRelationName(scanrel))));`
	`13642`	`+else`
	`13643`	`+ereport(INFO,`
	`13644`	`+(errmsg("updated partition constraint for default partition \"%s\" is implied by existing constraints",`
	`13645`	`+RelationGetRelationName(scanrel))));`
`13641`	`13646`	`return;`
`13642`	`13647`	`}`
`13643`	`13648`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3436,7 +3436,7 @@ ALTER TABLE part_7 ATTACH PARTITION part_7_a_null FOR VALUES IN ('a', null);`
`3436`	`3436`	`INFO: partition constraint for table "part_7_a_null" is implied by existing constraints`
`3437`	`3437`	`ALTER TABLE list_parted2 ATTACH PARTITION part_7 FOR VALUES IN (7);`
`3438`	`3438`	`INFO: partition constraint for table "part_7" is implied by existing constraints`
`3439`		`-INFO: partition constraint fortable "list_parted2_def" is implied by existing constraints`
	`3439`	`+INFO:updatedpartition constraint fordefault partition "list_parted2_def" is implied by existing constraints`
`3440`	`3440`	`-- Same example, but check this time that the constraint correctly detects`
`3441`	`3441`	`-- violating rows`
`3442`	`3442`	`ALTER TABLE list_parted2 DETACH PARTITION part_7;`
`@@ -3450,7 +3450,7 @@ SELECT tableoid::regclass, a, b FROM part_7 order by a;`
`3450`	`3450`	`(2 rows)`
`3451`	`3451`
`3452`	`3452`	`ALTER TABLE list_parted2 ATTACH PARTITION part_7 FOR VALUES IN (7);`
`3453`		`-INFO: partition constraint fortable "list_parted2_def" is implied by existing constraints`
	`3453`	`+INFO:updatedpartition constraint fordefault partition "list_parted2_def" is implied by existing constraints`
`3454`	`3454`	`ERROR: partition constraint is violated by some row`
`3455`	`3455`	`-- check that leaf partitions of default partition are scanned when`
`3456`	`3456`	`-- attaching a partitioned table.`

Comments

(0)