Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc2d7d67

Browse files
committed
Ensure acquire_inherited_sample_rows sets its output parameters.
The totalrows/totaldeadrows outputs were left uninitialized in caseswhere we find no analyzable child tables of a partitioned table. Thiscould lead to setting the partitioned table's pg_class.reltuples valueto garbage. It's not clear that that would have any very bad effectsin practice, but fix it anyway because it's making valgrind unhappy.Reported and diagnosed by Alexander Lakhin (bug #17880).Discussion:https://postgr.es/m/17880-9282037c923d856e@postgresql.org
1 parent558fff0 commitc2d7d67

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎src/backend/commands/analyze.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,6 +1389,10 @@ acquire_inherited_sample_rows(Relation onerel, int elevel,
13891389
ListCell*lc;
13901390
boolhas_child;
13911391

1392+
/* Initialize output parameters to zero now, in case we exit early */
1393+
*totalrows=0;
1394+
*totaldeadrows=0;
1395+
13921396
/*
13931397
* Find all members of inheritance set. We only need AccessShareLock on
13941398
* the children.
@@ -1522,8 +1526,6 @@ acquire_inherited_sample_rows(Relation onerel, int elevel,
15221526
pgstat_progress_update_param(PROGRESS_ANALYZE_CHILD_TABLES_TOTAL,
15231527
nrels);
15241528
numrows=0;
1525-
*totalrows=0;
1526-
*totaldeadrows=0;
15271529
for (i=0;i<nrels;i++)
15281530
{
15291531
Relationchildrel=rels[i];

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp