Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc2b68b1

Browse files
committed
initdb -S should now have an explicit check that $PGDATA is valid.
The fsync code from the backend essentially assumes that somebody's alreadyvalidated PGDATA, at least to the extent of it being a readable directory.That's safe enough for initdb's normal code path too, but "initdb -S"doesn't have any other processing at all that touches the target directory.To have reasonable error-case behavior, add a pg_check_dir call.Per gripe from Peter E.
1 parent35dd1b5 commitc2b68b1

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

‎src/bin/initdb/initdb.c

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3650,10 +3650,19 @@ main(int argc, char *argv[])
36503650
exit(1);
36513651
}
36523652

3653-
/* If we only need to fsync, justto it and exit */
3653+
/* If we only need to fsync, justdo it and exit */
36543654
if (sync_only)
36553655
{
36563656
setup_pgdata();
3657+
3658+
/* must check that directory is readable */
3659+
if (pg_check_dir(pg_data) <=0)
3660+
{
3661+
fprintf(stderr,_("%s: could not access directory \"%s\": %s\n"),
3662+
progname,pg_data,strerror(errno));
3663+
exit_nicely();
3664+
}
3665+
36573666
fsync_pgdata();
36583667
return0;
36593668
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp