NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc2a465b

committed

Suppress -Wunused-result warning about write().

pg_test_fsync's signal_cleanup() intentionally ignores the write()result since there's not much we could do about it, but certaincompilers make that harder than it ought to be.This was missed in commit52e98d4.Reviewed-by: Tristan Partin, Peter EisentrautDiscussion:https://postgr.es/m/20231206161839.GA2828158%40nathanxps13

1 parent52e98d4 commitc2a465bCopy full SHA for c2a465b

File tree

1 file changed

-1

lines changed

src/bin/pg_test_fsync
- pg_test_fsync.c

1 file changed

-1

lines changed

`‎src/bin/pg_test_fsync/pg_test_fsync.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -598,11 +598,14 @@ test_non_sync(void)`
`598`	`598`	`staticvoid`
`599`	`599`	`signal_cleanup(SIGNAL_ARGS)`
`600`	`600`	`{`
	`601`	`+intrc;`
	`602`	`+`
`601`	`603`	`/* Delete the file if it exists. Ignore errors */`
`602`	`604`	`if (needs_unlink)`
`603`	`605`	`unlink(filename);`
`604`	`606`	`/* Finish incomplete line on stdout */`
`605`		`-write(STDOUT_FILENO,"\n",1);`
	`607`	`+rc=write(STDOUT_FILENO,"\n",1);`
	`608`	`+(void)rc;/* silence compiler warnings */`
`606`	`609`	`_exit(1);`
`607`	`610`	`}`
`608`	`611`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc2a465b

File tree

1 file changed

1 file changed

`‎src/bin/pg_test_fsync/pg_test_fsync.c`

0 commit comments