NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc26d46f

committed

Fix corner-case coredump in _SPI_error_callback().

I noticed that _SPI_execute_plan initially sets spierrcontext.arg = NULL,and only fills it in some time later. If an error were to happen inbetween, _SPI_error_callback would try to dereference the null pointer.This is unlikely --- there's not much between those points exceptpush-snapshot calls --- but it's clearly not impossible. Tweak thecallback to do nothing if the pointer isn't set yet.It's been like this for awhile, so back-patch to all supported branches.

1 parent055532b commitc26d46fCopy full SHA for c26d46f

File tree

1 file changed

-0

lines changed

src/backend/executor
- spi.c

1 file changed

-0

lines changed

`‎src/backend/executor/spi.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2450,6 +2450,9 @@ _SPI_error_callback(void *arg)`
`2450`	`2450`	`constcharquery= (constchar)arg;`
`2451`	`2451`	`intsyntaxerrposition;`
`2452`	`2452`
	`2453`	`+if (query==NULL)/* in case arg wasn't set yet */`
	`2454`	`+return;`
	`2455`	`+`
`2453`	`2456`	`/*`
`2454`	`2457`	`* If there is a syntax error position, convert to internal syntax error;`
`2455`	`2458`	`* otherwise treat the query as an item of context stack`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc26d46f

File tree

1 file changed

1 file changed

`‎src/backend/executor/spi.c`

0 commit comments