NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc21e6e2

committed

Clear CurrentResourceOwner earlier in CommitTransaction.

Alexander reported a crash with repeated create + drop database, afterthe ResourceOwner rewrite (commitb8bff07). That was fixed by theprevious commit, but it nevertheless seems like a good idea clearCurrentResourceOwner earlier, because you're not supposed to use itfor anything after we start releasing it.Reviewed-by: Alexander LakhinDiscussion:https://www.postgresql.org/message-id/11b70743-c5f3-3910-8e5b-dd6c115ff829%40gmail.com

1 parent325f540 commitc21e6e2Copy full SHA for c21e6e2

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- xact.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/xact.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2309,6 +2309,7 @@ CommitTransaction(void)`
`2309`	`2309`	`CallXactCallbacks(is_parallel_worker ?XACT_EVENT_PARALLEL_COMMIT`
`2310`	`2310`	`:XACT_EVENT_COMMIT);`
`2311`	`2311`
	`2312`	`+CurrentResourceOwner=NULL;`
`2312`	`2313`	`ResourceOwnerRelease(TopTransactionResourceOwner,`
`2313`	`2314`	`RESOURCE_RELEASE_BEFORE_LOCKS,`
`2314`	`2315`	`true, true);`
`@@ -2374,7 +2375,6 @@ CommitTransaction(void)`
`2374`	`2375`	`AtEOXact_LogicalRepWorkers(true);`
`2375`	`2376`	`pgstat_report_xact_timestamp(0);`
`2376`	`2377`
`2377`		`-CurrentResourceOwner=NULL;`
`2378`	`2378`	`ResourceOwnerDelete(TopTransactionResourceOwner);`
`2379`	`2379`	`s->curTransactionOwner=NULL;`
`2380`	`2380`	`CurTransactionResourceOwner=NULL;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc21e6e2

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xact.c`

0 commit comments