NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc2138f3

committed

Fix minor memory leak introduced in recent SQL-functions hacking: the

DestReceiver created during postquel_start needs to be destroyed duringpostquel_end. In a moment of brain fade I had assumed this would be takencare of by FreeQueryDesc, but it's not (and shouldn't be).

1 parent9858a8c commitc2138f3Copy full SHA for c2138f3

File tree

1 file changed

-1

lines changed

src/backend/executor
- functions.c

1 file changed

-1

lines changed

`‎src/backend/executor/functions.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.128 2008/10/31 21:07:55 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/executor/functions.c,v 1.129 2008/11/27 00:10:04 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -501,6 +501,8 @@ postquel_end(execution_state *es)`
`501`	`501`	`PopActiveSnapshot();`
`502`	`502`	`}`
`503`	`503`
	`504`	`+(*es->qd->dest->rDestroy) (es->qd->dest);`
	`505`	`+`
`504`	`506`	`FreeQueryDesc(es->qd);`
`505`	`507`	`es->qd=NULL;`
`506`	`508`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc2138f3

File tree

1 file changed

1 file changed

`‎src/backend/executor/functions.c`

0 commit comments