NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc1b242b

committed

Fix potential coredump on bad locale value in pg_upgrade.

Thinko in error report (and a typo in the message text, too). We'refailing anyway, but it would be good to print something useful first.Noted while reviewing a patch to make pg_upgrade's locale code laxer.

1 parenta4aa854 commitc1b242bCopy full SHA for c1b242b

File tree

1 file changed

-1

lines changed

contrib/pg_upgrade
- check.c

1 file changed

-1

lines changed

`‎contrib/pg_upgrade/check.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1004,7 +1004,7 @@ get_canonical_locale_name(int category, const char *locale)`
`1004`	`1004`	`res=setlocale(category,locale);`
`1005`	`1005`
`1006`	`1006`	`if (!res)`
`1007`		`-pg_log(PG_FATAL,"failed to get systemlocal name for \"%s\"\n",res);`
	`1007`	`+pg_log(PG_FATAL,"failed to get systemlocale name for \"%s\"\n",locale);`
`1008`	`1008`
`1009`	`1009`	`res=pg_strdup(res);`
`1010`	`1010`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc1b242b

File tree

1 file changed

1 file changed

`‎contrib/pg_upgrade/check.c`

0 commit comments