NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc19024d

committed

Add missing bad-PGconn guards in libpq entry points.

There's a convention that externally-visible libpq functions shouldcheck for a NULL PGconn pointer, and fail gracefully instead ofcrashing. PQflush() and PQisnonblocking() didn't get that memothough. Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL;while it's not clear that ordinary usage could reach that with anull conn pointer, it's cheap enough to check, so let's be consistent.Daniele Varrazzo and Tom LaneDiscussion:https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com

1 parente2915af commitc19024dCopy full SHA for c19024d

File tree

1 file changed

-0

lines changed

src/interfaces/libpq
- fe-exec.c

1 file changed

-0

lines changed

`‎src/interfaces/libpq/fe-exec.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3268,6 +3268,8 @@ PQsetnonblocking(PGconn *conn, int arg)`
`3268`	`3268`	`int`
`3269`	`3269`	`PQisnonblocking(constPGconn*conn)`
`3270`	`3270`	`{`
	`3271`	`+if (!conn\|\|conn->status==CONNECTION_BAD)`
	`3272`	`+return false;`
`3271`	`3273`	`returnpqIsnonblocking(conn);`
`3272`	`3274`	`}`
`3273`	`3275`
`@@ -3287,6 +3289,8 @@ PQisthreadsafe(void)`
`3287`	`3289`	`int`
`3288`	`3290`	`PQflush(PGconn*conn)`
`3289`	`3291`	`{`
	`3292`	`+if (!conn\|\|conn->status==CONNECTION_BAD)`
	`3293`	`+return-1;`
`3290`	`3294`	`returnpqFlush(conn);`
`3291`	`3295`	`}`
`3292`	`3296`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc19024d

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-exec.c`

0 commit comments