Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc14a9ee

Browse files
committed
Avoid instabilities with the regression tests of pg_freespacemap
It was possible to run those tests with installcheck, but they areactually unstable as concurrent autovacuum jobs could prevent thetruncation of the filespace map to happen (aka the scan of pg_databasewhen building the list of relations to clean), an assumption we rely onwhen checking that the FSM of the relation gets truncated during amanual vacuum after deleting all the relation's data.This commit adds a NO_INSTALLCHECK to disallow installcheck, andintroduces the use of a custom configuration file with autovacuumdisabled.It happens that we already do that in the recovery test008_fsm_truncation, for example.Reported-by: Tom Lane, via buildfarm member skinkDiscussion:https://postgr.es/m/381910.1648401526@sss.pgh.pa.us
1 parenta2c8499 commitc14a9ee

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

‎contrib/pg_freespacemap/Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,13 @@ DATA = pg_freespacemap--1.1.sql pg_freespacemap--1.1--1.2.sql \
1010
pg_freespacemap--1.0--1.1.sql
1111
PGFILEDESC = "pg_freespacemap - monitoring of free space map"
1212

13+
REGRESS_OPTS = --temp-config$(top_srcdir)/contrib/pg_freespacemap/pg_freespacemap.conf
1314
REGRESS = pg_freespacemap
1415

16+
# Disabled because these tests require "autovacuum=off", which
17+
# typical installcheck users do not have (e.g. buildfarm clients).
18+
NO_INSTALLCHECK = 1
19+
1520
ifdefUSE_PGXS
1621
PG_CONFIG = pg_config
1722
PGXS :=$(shell$(PG_CONFIG) --pgxs)
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
autovacuum = off

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp