forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitc0e1903
committed
MinGW: Include .dll extension in .def file LIBRARY commands.
Newer toolchains append the extension implicitly if missing, butbuildfarm member narwhal (gcc 3.4.2, ld 2.15.91 20040904) does not.This affects most core libraries having an exports.txt file, namelylibpq and the ECPG support libraries. On Windows Server 2003, WindowsAPI functions that load and unload DLLs internally will mistakenlyunload a libpq whose DLL header reports "LIBPQ" instead of "LIBPQ.dll".When, subsequently, control would return to libpq, the backend crashes.Back-patch to 9.4, like commit846e91e.Before that commit, we used a different linking technique that yielded"libpq.dll" in the DLL header.Commit53566fc worked around this byeliminating a call to a function that loads and unloads DLLs internally.That commit is no longer necessary for correctness, but its improvingconsistency with the MSVC build remains valid.1 parent7f609a1 commitc0e1903
1 file changed
+2
-2
lines changedLines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
423 | 423 |
| |
424 | 424 |
| |
425 | 425 |
| |
426 |
| - | |
| 426 | + | |
427 | 427 |
| |
428 | 428 |
| |
429 | 429 |
| |
430 | 430 |
| |
431 | 431 |
| |
432 |
| - | |
| 432 | + | |
433 | 433 |
| |
434 | 434 |
| |
435 | 435 |
| |
|
0 commit comments
Comments
(0)