NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitc03a6ae

committed

Use correctly-sized buffer when zero-filling a WAL file.

I mixed up BLCKSZ and XLOG_BLCKSZ when I changed the way the buffer isallocated a couple of weeks ago. With the default settings, they are both8k, but they can be changed at compile-time.

1 parent3b8fda6 commitc03a6aeCopy full SHA for c03a6ae

File tree

1 file changed

-2

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-2

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2247,7 +2247,7 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)`
`2247`	`2247`	`{`
`2248`	`2248`	`charpath[MAXPGPATH];`
`2249`	`2249`	`chartmppath[MAXPGPATH];`
`2250`		`-charzbuffer_raw[BLCKSZ+MAXIMUM_ALIGNOF];`
	`2250`	`+charzbuffer_raw[XLOG_BLCKSZ+MAXIMUM_ALIGNOF];`
`2251`	`2251`	`char*zbuffer;`
`2252`	`2252`	`XLogSegNoinstalled_segno;`
`2253`	`2253`	`intmax_advance;`
`@@ -2307,7 +2307,7 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)`
`2307`	`2307`	`* cycles transferring data to the kernel.`
`2308`	`2308`	`*/`
`2309`	`2309`	`zbuffer= (char*)MAXALIGN(zbuffer_raw);`
`2310`		`-memset(zbuffer,0,BLCKSZ);`
	`2310`	`+memset(zbuffer,0,XLOG_BLCKSZ);`
`2311`	`2311`	`for (nbytes=0;nbytes<XLogSegSize;nbytes+=XLOG_BLCKSZ)`
`2312`	`2312`	`{`
`2313`	`2313`	`errno=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc03a6ae

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments