Commitbff258a

committed

pgstat: rename pgstat_initstats() to pgstat_relation_init().

The old name was overly generic. An upcoming commit moves relation statshandling into its own file, making pgstat_initstats() look even more out ofplace.Author: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de

1 parent8363102 commitbff258aCopy full SHA for bff258a

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ relation_open(Oid relationId, LOCKMODE lockmode)`
`73`	`73`	`if (RelationUsesLocalBuffers(r))`
`74`	`74`	`MyXactFlags \|=XACT_FLAGS_ACCESSEDTEMPNAMESPACE;`
`75`	`75`
`76`		`-pgstat_initstats(r);`
	`76`	`+pgstat_relation_init(r);`
`77`	`77`
`78`	`78`	`returnr;`
`79`	`79`	`}`
`@@ -123,7 +123,7 @@ try_relation_open(Oid relationId, LOCKMODE lockmode)`
`123`	`123`	`if (RelationUsesLocalBuffers(r))`
`124`	`124`	`MyXactFlags \|=XACT_FLAGS_ACCESSEDTEMPNAMESPACE;`
`125`	`125`
`126`		`-pgstat_initstats(r);`
	`126`	`+pgstat_relation_init(r);`
`127`	`127`
`128`	`128`	`returnr;`
`129`	`129`	`}`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ static bool pgStatRunningInCollector = false;`
`188`	`188`	`* for the life of the backend. Also, we zero out the t_id fields of the`
`189`	`189`	`* contained PgStat_TableStatus structs whenever they are not actively in use.`
`190`	`190`	`* This allows relcache pgstat_info pointers to be treated as long-lived data,`
`191`		`- * avoiding repeated searches inpgstat_initstats() when a relation is`
	`191`	`+ * avoiding repeated searches inpgstat_relation_init() when a relation is`
`192`	`192`	`* repeatedly opened during a transaction.`
`193`	`193`	`*/`
`194`	`194`	`#defineTABSTAT_QUANTUM100/* we alloc this many at a time */`
`@@ -2147,7 +2147,7 @@ pgstat_end_function_usage(PgStat_FunctionCallUsage *fcu, bool finalize)`
`2147`	`2147`
`2148`	`2148`
`2149`	`2149`	`/* ----------`
`2150`		`- *pgstat_initstats() -`
	`2150`	`+ *pgstat_relation_init() -`
`2151`	`2151`	`*`
`2152`	`2152`	`*Initialize a relcache entry to count access statistics.`
`2153`	`2153`	`*Called whenever a relation is opened.`
`@@ -2159,7 +2159,7 @@ pgstat_end_function_usage(PgStat_FunctionCallUsage *fcu, bool finalize)`
`2159`	`2159`	`* ----------`
`2160`	`2160`	`*/`
`2161`	`2161`	`void`
`2162`		`-pgstat_initstats(Relationrel)`
	`2162`	`+pgstat_relation_init(Relationrel)`
`2163`	`2163`	`{`
`2164`	`2164`	`Oidrel_id=rel->rd_id;`
`2165`	`2165`	`charrelkind=rel->rd_rel->relkind;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1102,7 +1102,7 @@ extern void pgstat_initialize(void);`
`1102`	`1102`	`externPgStat_TableStatus*find_tabstat_entry(Oidrel_id);`
`1103`	`1103`	`externPgStat_BackendFunctionEntry*find_funcstat_entry(Oidfunc_id);`
`1104`	`1104`
`1105`		`-externvoidpgstat_initstats(Relationrel);`
	`1105`	`+externvoidpgstat_relation_init(Relationrel);`
`1106`	`1106`
`1107`	`1107`	`#definepgstat_relation_should_count(rel) \`
`1108`	`1108`	`(likely((rel)->pgstat_info != NULL))`

Comments

(0)