NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbfe2e84

committed

Remove -Wl,-undefined,dynamic_lookup in macOS build.

We don't need this anymore, and it prevents build-time error checkingthat's usually good to have, so remove it. Undoes one change of commitcac7658.Unfortunately, it's much harder to get a similar effect on other commonplatforms, because we don't want the linker to throw errors for symbolsthat will be resolved in the core backend. Only macOS and AIX expect thecore backend executable to be available while linking loadable modules,so only these platforms can usefully throw errors for unresolved symbolsat link time.Discussion: <2652.1475512158@sss.pgh.pa.us>

1 parent11c0e74 commitbfe2e84Copy full SHA for bfe2e84

File tree

1 file changed

-1

lines changed

src
- Makefile.shlib

1 file changed

-1

lines changed

`‎src/Makefile.shlib`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ ifeq ($(PORTNAME), darwin)`
`127`	`127`	`else`
`128`	`128`	`# loadable module`
`129`	`129`	`DLSUFFIX= .so`
`130`		`- LINK.shared= $(COMPILER) -bundle -multiply_defined suppress -Wl,-undefined,dynamic_lookup`
	`130`	`+ LINK.shared= $(COMPILER) -bundle -multiply_defined suppress`
`131`	`131`	`endif`
`132`	`132`	`BUILD.exports= $(AWK) '/^[^\#]/ {printf "_%s\n",$$1}' $< >$@`
`133`	`133`	`exports_file= $(SHLIB_EXPORTS:%.txt=%.list)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbfe2e84

File tree

1 file changed

1 file changed

`‎src/Makefile.shlib`

0 commit comments