Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitbf183f1

Browse files
committed
Get rid of anonymous struct
This is a C11 feature, and we require C99. While at it, go the furtherstep and get rid of the surrounding union (with uintptr_t) entirely,as there is currently no use case for this file to access the header ofBlocktableEntry as a uintptr_t, and there are no additional alignmentrequirements. The least invasive way seems to be to transfer the oldunion name to this struct.Reported by Pavel Borisov and Andres Freund, per buildfarm member mylodonReviewed by Pavel BorisovDiscussion:https://postgr.es/m/CALT9ZEH11NYV8AOzKb1bWhCf6J0H=H31f0MgT9xX+HdqvcA1rw@mail.gmail.com
1 parentbaa82b7 commitbf183f1

File tree

1 file changed

+21
-22
lines changed

1 file changed

+21
-22
lines changed

‎src/backend/access/common/tidstore.c‎

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -43,37 +43,36 @@
4343
*/
4444
typedefstructBlocktableEntry
4545
{
46-
union
46+
struct
4747
{
48-
struct
49-
{
5048
#ifndefWORDS_BIGENDIAN
51-
/*
52-
* We need to position this member so that the backing radix tree
53-
* can use the lowest bit for a pointer tag. In particular, it
54-
* must be placed within 'header' so that it corresponds to the
55-
* lowest byte in 'ptr'. We position 'nwords' along with it to
56-
* avoid struct padding.
57-
*/
58-
uint8flags;
59-
60-
int8nwords;
49+
/*
50+
* We need to position this member to reserve space for the backing
51+
* radix tree to tag the lowest bit when struct 'header' is stored
52+
* inside a pointer or DSA pointer.
53+
*/
54+
uint8flags;
55+
56+
int8nwords;
6157
#endif
6258

63-
/*
64-
* We can store a small number of offsets here to avoid wasting
65-
* space with a sparse bitmap.
66-
*/
67-
OffsetNumberfull_offsets[NUM_FULL_OFFSETS];
59+
/*
60+
* We can store a small number of offsets here to avoid wasting space
61+
* with a sparse bitmap.
62+
*/
63+
OffsetNumberfull_offsets[NUM_FULL_OFFSETS];
6864

6965
#ifdefWORDS_BIGENDIAN
70-
int8nwords;
71-
uint8flags;
66+
int8nwords;
67+
uint8flags;
7268
#endif
73-
};
74-
uintptr_tptr;
7569
}header;
7670

71+
/*
72+
* We don't expect any padding space here, but to be cautious, code
73+
* creating new entries should zero out space up to 'words'.
74+
*/
75+
7776
bitmapwordwords[FLEXIBLE_ARRAY_MEMBER];
7877
}BlocktableEntry;
7978

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp