NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbe93954

committed

Fix broken compare function for tsquery_ops. Per Tom's report.

I never understood why initial authors GiST in pgsql choose sostgrange signature for 'same' method:bool *sameFn(Datum a, Datum b, bool* result)instead of simple, logicalbool sameFn(Datum a, Datum b)This change will break any existing GiST extension, so we still live withit and will live.

1 parentdc192a5 commitbe93954Copy full SHA for be93954

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- tsquery_gist.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/tsquery_gist.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/tsquery_gist.c,v 1.5 2008/04/1417:05:33 tgl Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/tsquery_gist.c,v 1.6 2008/04/20 09:17:57 teodor Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -106,8 +106,11 @@ gtsquery_same(PG_FUNCTION_ARGS)`
`106`	`106`	`{`
`107`	`107`	`TSQuerySigna= (TSQuerySign)PG_GETARG_POINTER(0);`
`108`	`108`	`TSQuerySignb= (TSQuerySign)PG_GETARG_POINTER(1);`
	`109`	`+boolresult= (bool)PG_GETARG_POINTER(2);`
`109`	`110`
`110`		`-PG_RETURN_POINTER(a==b);`
	`111`	`+result= (a==*b) ? true : false;`
	`112`	`+`
	`113`	`+PG_RETURN_POINTER(result);`
`111`	`114`	`}`
`112`	`115`
`113`	`116`	`staticint`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbe93954

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/tsquery_gist.c`

0 commit comments