NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbe850f1

committed

Copy a Param's location field when replacing it with a Const.

This allows Param substitution to produce just the same resultas writing a constant value literally would have done. Whileit hardly matters so far as the current core code is concerned,extensions might take more interest in node location fields.Julien RouhaudDiscussion:https://postgr.es/m/20170311220932.GJ15188@nol.local

1 parentc203dcd commitbe850f1Copy full SHA for be850f1

File tree

1 file changed

+10

-7

lines changed

src/backend/optimizer/util
- clauses.c

1 file changed

+10

-7

lines changed

`‎src/backend/optimizer/util/clauses.c`

Lines changed: 10 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -2329,20 +2329,23 @@ eval_const_expressions_mutator(Node *node,`
`2329`	`2329`	`int16typLen;`
`2330`	`2330`	`booltypByVal;`
`2331`	`2331`	`Datumpval;`
	`2332`	`+Const*con;`
`2332`	`2333`
`2333`	`2334`	`get_typlenbyval(param->paramtype,`
`2334`	`2335`	`&typLen,&typByVal);`
`2335`	`2336`	`if (prm->isnull\|\|typByVal)`
`2336`	`2337`	`pval=prm->value;`
`2337`	`2338`	`else`
`2338`	`2339`	`pval=datumCopy(prm->value,typByVal,typLen);`
`2339`		`-return (Node*)makeConst(param->paramtype,`
`2340`		`-param->paramtypmod,`
`2341`		`-param->paramcollid,`
`2342`		`- (int)typLen,`
`2343`		`-pval,`
`2344`		`-prm->isnull,`
`2345`		`-typByVal);`
	`2340`	`+con=makeConst(param->paramtype,`
	`2341`	`+param->paramtypmod,`
	`2342`	`+param->paramcollid,`
	`2343`	`+(int)typLen,`
	`2344`	`+pval,`
	`2345`	`+prm->isnull,`
	`2346`	`+typByVal);`
	`2347`	`+con->location=param->location;`
	`2348`	`+return (Node*)con;`
`2346`	`2349`	`}`
`2347`	`2350`	`}`
`2348`	`2351`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbe850f1

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/clauses.c`

0 commit comments