NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbe57f21

Amit Kapila

committed

Remove two_phase variable from CreateReplicationSlotCmd struct.

Commit19890a0 added the option to enable two_phase commits viapg_create_logical_replication_slot but didn't extend the support of samein replication protocol. However, by mistake, it added the two_phasevariable in CreateReplicationSlotCmd which is required only when we extendthe replication protocol.Reported-by: Jeff DavisAuthor: Ajin CherianReviewed-by: Amit KapilaDiscussion:https://postgr.es/m/64b9f783c6e125f18f88fbc0c0234e34e71d8639.camel@j-davis.com

1 parentf3baaf2 commitbe57f21Copy full SHA for be57f21

File tree

2 files changed

-2

lines changed

src
- backend/replication
  - walsender.c
- include/nodes
  - replnodes.h

2 files changed

-2

lines changed

`‎src/backend/replication/walsender.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -954,7 +954,7 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)`
`954`	`954`	`*/`
`955`	`955`	`ReplicationSlotCreate(cmd->slotname, true,`
`956`	`956`	`cmd->temporary ?RS_TEMPORARY :RS_EPHEMERAL,`
`957`		`-cmd->two_phase);`
	`957`	`+false);`
`958`	`958`	`}`
`959`	`959`
`960`	`960`	`if (cmd->kind==REPLICATION_KIND_LOGICAL)`

`‎src/include/nodes/replnodes.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ typedef struct CreateReplicationSlotCmd`
`56`	`56`	`ReplicationKindkind;`
`57`	`57`	`char*plugin;`
`58`	`58`	`booltemporary;`
`59`		`-booltwo_phase;`
`60`	`59`	`List*options;`
`61`	`60`	`}CreateReplicationSlotCmd;`
`62`	`61`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbe57f21

File tree

2 files changed

2 files changed

`‎src/backend/replication/walsender.c`

`‎src/include/nodes/replnodes.h`

0 commit comments