NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbe02b16

committed

Delete the temporary file used in buffered GiST build, after the build.

There were two bugs here: We forgot to call gistFreeBuildBuffers() functionat the end of build, and we passed interXact == true to BufFileCreateTemp,so the file wasn't automatically cleaned up at end-of-transaction either.

1 parent4317e02 commitbe02b16Copy full SHA for be02b16

File tree

2 files changed

-1

lines changed

src/backend/access/gist
- gistbuild.c
- gistbuildbuffers.c

2 files changed

-1

lines changed

`‎src/backend/access/gist/gistbuild.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -214,6 +214,7 @@ gistbuild(PG_FUNCTION_ARGS)`
`214`	`214`	`{`
`215`	`215`	`elog(DEBUG1,"all tuples processed, emptying buffers");`
`216`	`216`	`gistEmptyAllBuffers(&buildstate);`
	`217`	`+gistFreeBuildBuffers(buildstate.gfbb);`
`217`	`218`	`}`
`218`	`219`
`219`	`220`	`/* okay, all heap tuples are indexed */`

`‎src/backend/access/gist/gistbuildbuffers.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ gistInitBuildBuffers(int pagesPerBuffer, int levelStep, int maxLevel)`
`58`	`58`	`* Create a temporary file to hold buffer pages that are swapped out of`
`59`	`59`	`* memory.`
`60`	`60`	`*/`
`61`		`-gfbb->pfile=BufFileCreateTemp(true);`
	`61`	`+gfbb->pfile=BufFileCreateTemp(false);`
`62`	`62`	`gfbb->nFileBlocks=0;`
`63`	`63`
`64`	`64`	`/* Initialize free page management. */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbe02b16

File tree

2 files changed

2 files changed

`‎src/backend/access/gist/gistbuild.c`

`‎src/backend/access/gist/gistbuildbuffers.c`

0 commit comments