NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbdc79dd

committed

Fix ancient bug in ecpg's pthread_once() emulation for Windows.

We must not set the "done" flag until after we've executed theinitialization function. Otherwise, other threads can fall throughthe initial unlocked test before initialization is really complete.This has been seen to cause rare failures of ecpg's thread/descriptortest, and it could presumably cause other sorts of misbehavior inthreaded ECPG-using applications, since ecpglib relies onpthread_once() in several places.Diagnosis and patch by me, based on investigation by Alexander Lakhin.Back-patch to all supported branches (the bug dates to 2007).Discussion:https://postgr.es/m/16685-d6cd241872c101d3@postgresql.org

1 parent78ccf7f commitbdc79ddCopy full SHA for bdc79dd

File tree

1 file changed

-1

lines changed

src/interfaces/ecpg/ecpglib
- misc.c

1 file changed

-1

lines changed

`‎src/interfaces/ecpg/ecpglib/misc.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -482,8 +482,8 @@ win32_pthread_once(volatile pthread_once_t once, void (fn) (void))`
`482`	`482`	`pthread_mutex_lock(&win32_pthread_once_lock);`
`483`	`483`	`if (!*once)`
`484`	`484`	`{`
`485`		`-*once= true;`
`486`	`485`	`fn();`
	`486`	`+*once= true;`
`487`	`487`	`}`
`488`	`488`	`pthread_mutex_unlock(&win32_pthread_once_lock);`
`489`	`489`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbdc79dd

File tree

1 file changed

1 file changed

`‎src/interfaces/ecpg/ecpglib/misc.c`

0 commit comments