NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbdc643e

committed

Fix access to just-closed relcache entry.

It might be impossible for this to cause a problem in non-debug builds,since there'd be no opportunity for the relcache entry to get recycledbefore the fetch. It blows up nicely with -DRELCACHE_FORCE_RELEASE plusvalgrind, though.Evidently introduced by careless refactoring in commitf0e4475.Back-patch accordingly.Discussion:https://postgr.es/m/27543.1528758304@sss.pgh.pa.us

1 parentf8795d2 commitbdc643eCopy full SHA for bdc643e

File tree

1 file changed

-3

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-3

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -11922,12 +11922,12 @@ ATExecDropInherit(Relation rel, RangeVar *parent, LOCKMODE lockmode)`
`11922`	`11922`	`/* Off to RemoveInheritance() where most of the work happens */`
`11923`	`11923`	`RemoveInheritance(rel,parent_rel);`
`11924`	`11924`
`11925`		`-/* keep our lock on the parent relation until commit */`
`11926`		`-heap_close(parent_rel,NoLock);`
`11927`		`-`
`11928`	`11925`	`ObjectAddressSet(address,RelationRelationId,`
`11929`	`11926`	`RelationGetRelid(parent_rel));`
`11930`	`11927`
	`11928`	`+/* keep our lock on the parent relation until commit */`
	`11929`	`+heap_close(parent_rel,NoLock);`
	`11930`	`+`
`11931`	`11931`	`returnaddress;`
`11932`	`11932`	`}`
`11933`	`11933`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbdc643e

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments