NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbdbf29a

committed

Update relation's stats in pg_class during vacuum full.

Hash index depends on estimation of numbers of tuples and pages of relations,incorrect value could be a reason of significantly growing of index. Vacuumfull recreates heap and reindex all indexes before renewal stats. The patchfixes that, so indexes will see correct values.Backpatch to v10 only because earlier versions haven't usable hash index andgrowing of hash index is a single user-visible symptom.Author: Amit KapilaReviewed-by: Ashutosh Sharma, meDiscussion:https://www.postgresql.org/message-id/flat/20171115232922.5tomkxnw3iq6jsg7@inml.weebeastie.net

1 parentc252ccd commitbdbf29aCopy full SHA for bdbf29a

File tree

1 file changed

+30

-0

lines changed

src/backend/commands
- cluster.c

1 file changed

+30

-0

lines changed

`‎src/backend/commands/cluster.c`

Lines changed: 30 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -738,6 +738,9 @@ copy_heap_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,`
`738`	`738`	`RelationNewHeap,`
`739`	`739`	`OldHeap,`
`740`	`740`	`OldIndex;`
	`741`	`+RelationrelRelation;`
	`742`	`+HeapTuplereltup;`
	`743`	`+Form_pg_classrelform;`
`741`	`744`	`TupleDescoldTupDesc;`
`742`	`745`	`TupleDescnewTupDesc;`
`743`	`746`	`intnatts;`
`@@ -756,6 +759,7 @@ copy_heap_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,`
`756`	`759`	`doublenum_tuples=0,`
`757`	`760`	`tups_vacuumed=0,`
`758`	`761`	`tups_recently_dead=0;`
	`762`	`+BlockNumbernum_pages;`
`759`	`763`	`intelevel=verbose ?INFO :DEBUG2;`
`760`	`764`	`PGRUsageru0;`
`761`	`765`
`@@ -1079,6 +1083,8 @@ copy_heap_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,`
`1079`	`1083`	`/* Reset rd_toastoid just to be tidy --- it shouldn't be looked at again */`
`1080`	`1084`	`NewHeap->rd_toastoid=InvalidOid;`
`1081`	`1085`
	`1086`	`+num_pages=RelationGetNumberOfBlocks(NewHeap);`
	`1087`	`+`
`1082`	`1088`	`/* Log what we did */`
`1083`	`1089`	`ereport(elevel,`
`1084`	`1090`	`(errmsg("\"%s\": found %.0f removable, %.0f nonremovable row versions in %u pages",`
`@@ -1098,6 +1104,30 @@ copy_heap_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,`
`1098`	`1104`	`index_close(OldIndex,NoLock);`
`1099`	`1105`	`heap_close(OldHeap,NoLock);`
`1100`	`1106`	`heap_close(NewHeap,NoLock);`
	`1107`	`+`
	`1108`	`+/* Update pg_class to reflect the correct values of pages and tuples. */`
	`1109`	`+relRelation=heap_open(RelationRelationId,RowExclusiveLock);`
	`1110`	`+`
	`1111`	`+reltup=SearchSysCacheCopy1(RELOID,ObjectIdGetDatum(OIDNewHeap));`
	`1112`	`+if (!HeapTupleIsValid(reltup))`
	`1113`	`+elog(ERROR,"cache lookup failed for relation %u",OIDNewHeap);`
	`1114`	`+relform= (Form_pg_class)GETSTRUCT(reltup);`
	`1115`	`+`
	`1116`	`+relform->relpages=num_pages;`
	`1117`	`+relform->reltuples=num_tuples;`
	`1118`	`+`
	`1119`	`+/* Don't update the stats for pg_class. See swap_relation_files. */`
	`1120`	`+if (OIDOldHeap!=RelationRelationId)`
	`1121`	`+CatalogTupleUpdate(relRelation,&reltup->t_self,reltup);`
	`1122`	`+else`
	`1123`	`+CacheInvalidateRelcacheByTuple(reltup);`
	`1124`	`+`
	`1125`	`+/* Clean up. */`
	`1126`	`+heap_freetuple(reltup);`
	`1127`	`+heap_close(relRelation,RowExclusiveLock);`
	`1128`	`+`
	`1129`	`+/* Make the update visible */`
	`1130`	`+CommandCounterIncrement();`
`1101`	`1131`	`}`
`1102`	`1132`
`1103`	`1133`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbdbf29a

File tree

1 file changed

1 file changed

`‎src/backend/commands/cluster.c`

0 commit comments