Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitbd88404

Browse files
Fix crash with RemoveFromWaitQueue() when detecting a deadlock.
Commit5764f61 used dclist_delete_from() to remove the proc from thewait queue. However, since it doesn't clear dist_node's next/prev toNULL, it could call RemoveFromWaitQueue() twice: when the processdetects a deadlock and then when cleaning up locks on aborting thetransaction. The waiting lock information is cleared in the firstcall, so it led to a crash in the second call.Backpatch to v16, where the change was introduced.Bug: #18031Reported-by: Justin Pryzby, Alexander LakhinReviewed-by: Andres FreundDiscussion:https://postgr.es/m/ZKy4AdrLEfbqrxGJ%40telsasoft.comDiscussion:https://postgr.es/m/18031-ebe2d08cb405f6cc@postgresql.orgBackpatch-through: 16
1 parentd9eb92c commitbd88404

File tree

1 file changed

+1
-1
lines changed
  • src/backend/storage/lmgr

1 file changed

+1
-1
lines changed

‎src/backend/storage/lmgr/lock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1881,7 +1881,7 @@ RemoveFromWaitQueue(PGPROC *proc, uint32 hashcode)
18811881
Assert(0<lockmethodid&&lockmethodid<lengthof(LockMethods));
18821882

18831883
/* Remove proc from lock's wait queue */
1884-
dclist_delete_from(&waitLock->waitProcs,&proc->links);
1884+
dclist_delete_from_thoroughly(&waitLock->waitProcs,&proc->links);
18851885

18861886
/* Undo increments of request counts by waiting process */
18871887
Assert(waitLock->nRequested>0);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp