Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitbd04184

Browse files
committed
Attached is a patch to fix some recently raised issues that exist in
contrib/tablefunc. Specifically it replaces the use of VIEWs (for neededcomposite type creation) with use of CREATE TYPE. It also performs GRANTEXECUTE ON FUNCTION foo() TO PUBLIC for all of the created functions. Therewas also a cosmetic change to two regression files.Joe Conway
1 parentf7978c6 commitbd04184

File tree

3 files changed

+33
-22
lines changed

3 files changed

+33
-22
lines changed

‎contrib/tablefunc/expected/tablefunc.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
--
22
-- first, define the functions. Turn off echoing so that expected file
3-
-- does not depend on contents ofseg.sql.
3+
-- does not depend on contents oftablefunc.sql.
44
--
55
\set ECHO none
66
--

‎contrib/tablefunc/sql/tablefunc.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
--
22
-- first, define the functions. Turn off echoing so that expected file
3-
-- does not depend on contents ofseg.sql.
3+
-- does not depend on contents oftablefunc.sql.
44
--
55
\set ECHO none
66
\itablefunc.sql

‎contrib/tablefunc/tablefunc.sql.in

Lines changed: 31 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,29 @@ CREATE OR REPLACE FUNCTION normal_rand(int4, float8, float8, int4)
22
RETURNS setof float8
33
AS 'MODULE_PATHNAME','normal_rand' LANGUAGE 'c' VOLATILE STRICT;
44

5-
CREATE VIEW tablefunc_crosstab_2 AS
6-
SELECT
7-
''::TEXT AS row_name,
8-
''::TEXT AS category_1,
9-
''::TEXT AS category_2;
10-
11-
CREATE VIEW tablefunc_crosstab_3 AS
12-
SELECT
13-
''::TEXT AS row_name,
14-
''::TEXT AS category_1,
15-
''::TEXT AS category_2,
16-
''::TEXT AS category_3;
17-
18-
CREATE VIEW tablefunc_crosstab_4 AS
19-
SELECT
20-
''::TEXT AS row_name,
21-
''::TEXT AS category_1,
22-
''::TEXT AS category_2,
23-
''::TEXT AS category_3,
24-
''::TEXT AS category_4;
5+
CREATE TYPE tablefunc_crosstab_2 AS
6+
(
7+
row_name TEXT,
8+
category_1 TEXT,
9+
category_2 TEXT
10+
);
11+
12+
CREATE TYPE tablefunc_crosstab_3 AS
13+
(
14+
row_name TEXT,
15+
category_1 TEXT,
16+
category_2 TEXT,
17+
category_3 TEXT
18+
);
19+
20+
CREATE TYPE tablefunc_crosstab_4 AS
21+
(
22+
row_name TEXT,
23+
category_1 TEXT,
24+
category_2 TEXT,
25+
category_3 TEXT,
26+
category_4 TEXT
27+
);
2528

2629
CREATE OR REPLACE FUNCTION crosstab2(text)
2730
RETURNS setof tablefunc_crosstab_2
@@ -46,3 +49,11 @@ CREATE OR REPLACE FUNCTION connectby(text,text,text,text,int,text)
4649
CREATE OR REPLACE FUNCTION connectby(text,text,text,text,int)
4750
RETURNS setof record
4851
AS 'MODULE_PATHNAME','connectby_text' LANGUAGE 'c' STABLE STRICT;
52+
53+
GRANT EXECUTE ON FUNCTION normal_rand(int4, float8, float8, int4) TO PUBLIC;
54+
GRANT EXECUTE ON FUNCTION crosstab2(text) TO PUBLIC;
55+
GRANT EXECUTE ON FUNCTION crosstab3(text) TO PUBLIC;
56+
GRANT EXECUTE ON FUNCTION crosstab4(text) TO PUBLIC;
57+
GRANT EXECUTE ON FUNCTION crosstab(text,int) TO PUBLIC;
58+
GRANT EXECUTE ON FUNCTION connectby(text,text,text,text,int,text) TO PUBLIC;
59+
GRANT EXECUTE ON FUNCTION connectby(text,text,text,text,int) TO PUBLIC;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp