Commitbcbf392

committed

Prevent table partitions from being turned into views.

A table partition must be a table, not a view, so don't allow a"_RETURN" rule to be added that would convert an existing tablepartition into a view.Amit LangoteDiscussion:https://postgr.es/m/CAEZATCVzFcAjZwC1bTFvJ09skB_sgkF4SwPKMywev-XTnimp9Q%40mail.gmail.com

1 parentba1f017 commitbcbf392Copy full SHA for bcbf392

File tree

+16

-0

lines changed

+16

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -428,6 +428,12 @@ DefineQueryRewrite(char *rulename,`
`428`	`428`	`errmsg("could not convert partitioned table \"%s\" to a view",`
`429`	`429`	`RelationGetRelationName(event_relation))));`
`430`	`430`
	`431`	`+if (event_relation->rd_rel->relispartition)`
	`432`	`+ereport(ERROR,`
	`433`	`+(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
	`434`	`+errmsg("could not convert partition \"%s\" to a view",`
	`435`	`+RelationGetRelationName(event_relation))));`
	`436`	`+`
`431`	`437`	`snapshot=RegisterSnapshot(GetLatestSnapshot());`
`432`	`438`	`scanDesc=heap_beginscan(event_relation,snapshot,0,NULL);`
`433`	`439`	`if (heap_getnext(scanDesc,ForwardScanDirection)!=NULL)`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2572,6 +2572,11 @@ create table fooview (x int, y text) partition by list (x);`
`2572`	`2572`	`create rule "_RETURN" as on select to fooview do instead`
`2573`	`2573`	`select 1 as x, 'aaa'::text as y;`
`2574`	`2574`	`ERROR: could not convert partitioned table "fooview" to a view`
	`2575`	`+-- nor can one convert a partition to view`
	`2576`	`+create table fooview_part partition of fooview for values in (1);`
	`2577`	`+create rule "_RETURN" as on select to fooview_part do instead`
	`2578`	`+ select 1 as x, 'aaa'::text as y;`
	`2579`	`+ERROR: could not convert partition "fooview_part" to a view`
`2575`	`2580`	`--`
`2576`	`2581`	`-- check for planner problems with complex inherited UPDATES`
`2577`	`2582`	`--`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -903,6 +903,11 @@ create table fooview (x int, y text) partition by list (x);`
`903`	`903`	`createrule "_RETURN"asonselect to fooview do instead`
`904`	`904`	`select1as x,'aaa'::textas y;`
`905`	`905`
	`906`	`+-- nor can one convert a partition to view`
	`907`	`+createtablefooview_part partition of fooview forvaluesin (1);`
	`908`	`+createrule "_RETURN"asonselect to fooview_part do instead`
	`909`	`+select1as x,'aaa'::textas y;`
	`910`	`+`
`906`	`911`	`--`
`907`	`912`	`-- check for planner problems with complex inherited UPDATES`
`908`	`913`	`--`

Comments

(0)