NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbca39b5

committed

Fix planning of SELECT FOR UPDATE on child table with partial index.

Ordinarily we can omit checking of a WHERE condition that matches a partialindex's condition, when we are using an indexscan on that partial index.However, in SELECT FOR UPDATE we must include the "redundant" filtercondition in the plan so that it gets checked properly in an EvalPlanQualrecheck. The planner got this mostly right, but improperly omitted thefilter condition if the index in question was on an inheritance childtable. In READ COMMITTED mode, this could result in incorrectly returningjust-updated rows that no longer satisfy the filter condition.The cause of the error is using get_parse_rowmark() when get_plan_rowmark()is what should be used during planning. In 9.3 and up, also fix the samemistake in contrib/postgres_fdw. It's currently harmless there (for lackof inheritance support) but wrong is wrong, and the incorrect code mightget copied to someplace where it's more significant.Report and fix by Kyotaro Horiguchi. Back-patch to all supported branches.

1 parent21946ac commitbca39b5Copy full SHA for bca39b5

File tree

1 file changed

-1

lines changed

src/backend/optimizer/plan
- createplan.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/plan/createplan.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@`
`31`	`31`	`#include"optimizer/plancat.h"`
`32`	`32`	`#include"optimizer/planmain.h"`
`33`	`33`	`#include"optimizer/predtest.h"`
	`34`	`+#include"optimizer/prep.h"`
`34`	`35`	`#include"optimizer/restrictinfo.h"`
`35`	`36`	`#include"optimizer/subselect.h"`
`36`	`37`	`#include"optimizer/tlist.h"`
`@@ -1159,7 +1160,7 @@ create_indexscan_plan(PlannerInfo *root,`
`1159`	`1160`	`if (best_path->indexinfo->indpred)`
`1160`	`1161`	`{`
`1161`	`1162`	`if (baserelid!=root->parse->resultRelation&&`
`1162`		`-get_parse_rowmark(root->parse,baserelid)==NULL)`
	`1163`	`+get_plan_rowmark(root->rowMarks,baserelid)==NULL)`
`1163`	`1164`	`if (predicate_implied_by(clausel,`
`1164`	`1165`	`best_path->indexinfo->indpred))`
`1165`	`1166`	`continue;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbca39b5

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/createplan.c`

0 commit comments