NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbbf4fdc

Neil Conway

committed

Prevent corr() from returning the wrong results for negative correlation

values. The previous coding essentially assumed that x = sqrt(x*x), whichdoes not hold for x < 0.Thanks to Jie Zhang at Greenplum and Gavin Sherry for reporting thisissue.

1 parent4893ead commitbbf4fdcCopy full SHA for bbf4fdc

File tree

1 file changed

-3

lines changed

src/backend/utils/adt
- float.c

1 file changed

-3

lines changed

`‎src/backend/utils/adt/float.c`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.150 2007/06/05 21:31:06 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.151 2007/09/19 22:31:48 neilc Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -2274,8 +2274,7 @@ float8_corr(PG_FUNCTION_ARGS)`
`2274`	`2274`	`if (numeratorX <=0\|\|numeratorY <=0)`
`2275`	`2275`	`PG_RETURN_NULL();`
`2276`	`2276`
`2277`		`-PG_RETURN_FLOAT8(sqrt((numeratorXY*numeratorXY) /`
`2278`		`- (numeratorX*numeratorY)));`
	`2277`	`+PG_RETURN_FLOAT8(numeratorXY /sqrt(numeratorX*numeratorY));`
`2279`	`2278`	`}`
`2280`	`2279`
`2281`	`2280`	`Datum`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbbf4fdc

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/float.c`

0 commit comments