Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitbbbf71d

Browse files
committed
Fix 002_pg_upgrade.pl.
Commitf696c0c caused a test failure in 002_pg_upgrade.pl, becausean earlier s/// operator caused qr// to no longer match the emptystring. Use qr/^$/ instead, which is a better test anyway, because weexpect the stderr to be empty.Initially this appeared to be a perl bug, but per discussion, it seemsthat it was a misunderstanding of how perl works: an empty patternuses the last successful pattern. Given how surprising that behavioris to perl non-experts, we will need to look for similar problemselsewhere and eliminate the use of empty patterns throughout thecode. For now, address this one instance to fix the buildfarm.Discussion:https://postgr.es/m/0ef325fa06e7a1605c4e119c4ecb637c67e5fb4e.camel@j-davis.comReviewed-by: Tom Lane
1 parent319e9e5 commitbbbf71d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/bin/pg_upgrade/t/002_pg_upgrade.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ sub filter_dump
377377
],
378378
1,
379379
[qr/invalid/],# pg_upgrade prints errors on stdout :(
380-
[qr//],
380+
[qr/^$/],
381381
'invalid database causes failure');
382382
rmtree($newnode->data_dir ."/pg_upgrade_output.d");
383383

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp