NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbbaf75e

committed

Fix simple_prompt() to disable echo on Windows when stdin != terminal.

If echo = false, simple_prompt() is supposed to prevent echoing theinput (for password input). However, the Windows implementation appliedthe mode change to STD_INPUT_HANDLE. That would not have the desiredeffect if stdin isn't actually the terminal, for instance if the useris piping something into psql. Fix it to apply the mode change tothe correct input file, so that passwords do not echo in such cases.In passing, shorten and de-uglify this code by using #elif rather thanan #if nest and removing some duplicated code.Back-patch to all supported versions. To simplify that, also back-patchthe portions of commit9daec77 that got rid of an unnecessarymalloc/free in the same area.Matthew Stickney (cosmetic changes by me)Discussion:https://postgr.es/m/502a1fff-862b-da52-1031-f68df6ed5a2d@gmail.com

1 parent588edd8 commitbbaf75eCopy full SHA for bbaf75e

File tree

1 file changed

+19

-29

lines changed

src/port
- sprompt.c

1 file changed

+19

-29

lines changed

`‎src/port/sprompt.c`

Lines changed: 19 additions & 29 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,14 +42,12 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`42`	`42`	`FILE*termin,`
`43`	`43`	`*termout;`
`44`	`44`
`45`		`-#ifdefHAVE_TERMIOS_H`
	`45`	`+#if defined(HAVE_TERMIOS_H)`
`46`	`46`	`structtermiost_orig,`
`47`	`47`	`t;`
`48`		`-#else`
`49`		`-#ifdefWIN32`
	`48`	`+#elif defined(WIN32)`
`50`	`49`	`HANDLEt=NULL;`
`51`		`-LPDWORDt_orig=NULL;`
`52`		`-#endif`
	`50`	`+DWORDt_orig=0;`
`53`	`51`	`#endif`
`54`	`52`
`55`	`53`	`destination= (char*)malloc(maxlen+1);`
`@@ -72,8 +70,11 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`72`	`70`	`*`
`73`	`71`	`* XXX fgets() still receives text in the console's input code page. This`
`74`	`72`	`* makes non-ASCII credentials unportable.`
	`73`	`+ *`
	`74`	`+ * Unintuitively, we also open termin in mode "w+", even though we only`
	`75`	`+ * read it; that's needed for SetConsoleMode() to succeed.`
`75`	`76`	`*/`
`76`		`-termin=fopen("CONIN$","r");`
	`77`	`+termin=fopen("CONIN$","w+");`
`77`	`78`	`termout=fopen("CONOUT$","w+");`
`78`	`79`	`#else`
`79`	`80`
`@@ -105,30 +106,25 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`105`	`106`	`termout=stderr;`
`106`	`107`	`}`
`107`	`108`
`108`		`-#ifdefHAVE_TERMIOS_H`
`109`	`109`	`if (!echo)`
`110`	`110`	`{`
	`111`	`+#if defined(HAVE_TERMIOS_H)`
	`112`	`+/* disable echo via tcgetattr/tcsetattr */`
`111`	`113`	`tcgetattr(fileno(termin),&t);`
`112`	`114`	`t_orig=t;`
`113`	`115`	`t.c_lflag &= ~ECHO;`
`114`	`116`	`tcsetattr(fileno(termin),TCSAFLUSH,&t);`
`115`		`-}`
`116`		`-#else`
`117`		`-#ifdefWIN32`
`118`		`-if (!echo)`
`119`		`-{`
`120`		`-/* get a new handle to turn echo off */`
`121`		`-t_orig= (LPDWORD)malloc(sizeof(DWORD));`
`122`		`-t=GetStdHandle(STD_INPUT_HANDLE);`
	`117`	`+#elif defined(WIN32)`
	`118`	`+/* need the file's HANDLE to turn echo off */`
	`119`	`+t= (HANDLE)_get_osfhandle(_fileno(termin));`
`123`	`120`
`124`	`121`	`/* save the old configuration first */`
`125`		`-GetConsoleMode(t,t_orig);`
	`122`	`+GetConsoleMode(t,&t_orig);`
`126`	`123`
`127`	`124`	`/* set to the new mode */`
`128`	`125`	`SetConsoleMode(t,ENABLE_LINE_INPUT \|ENABLE_PROCESSED_INPUT);`
`129`		`-}`
`130`		`-#endif`
`131`	`126`	`#endif`
	`127`	`+}`
`132`	`128`
`133`	`129`	`if (prompt)`
`134`	`130`	`{`
`@@ -158,25 +154,19 @@ simple_prompt(const char *prompt, int maxlen, bool echo)`
`158`	`154`	`/* remove trailing newline */`
`159`	`155`	`destination[length-1]='\0';`
`160`	`156`
`161`		`-#ifdefHAVE_TERMIOS_H`
`162`	`157`	`if (!echo)`
`163`	`158`	`{`
	`159`	`+/* restore previous echo behavior, then echo \n */`
	`160`	`+#if defined(HAVE_TERMIOS_H)`
`164`	`161`	`tcsetattr(fileno(termin),TCSAFLUSH,&t_orig);`
`165`	`162`	`fputs("\n",termout);`
`166`	`163`	`fflush(termout);`
`167`		`-}`
`168`		`-#else`
`169`		`-#ifdefWIN32`
`170`		`-if (!echo)`
`171`		`-{`
`172`		`-/* reset to the original console mode */`
`173`		`-SetConsoleMode(t,*t_orig);`
	`164`	`+#elif defined(WIN32)`
	`165`	`+SetConsoleMode(t,t_orig);`
`174`	`166`	`fputs("\n",termout);`
`175`	`167`	`fflush(termout);`
`176`		`-free(t_orig);`
`177`		`-}`
`178`		`-#endif`
`179`	`168`	`#endif`
	`169`	`+}`
`180`	`170`
`181`	`171`	`if (termin!=stdin)`
`182`	`172`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbbaf75e

File tree

1 file changed

1 file changed

`‎src/port/sprompt.c`

0 commit comments