Commitbb93640

committed

Add wait event type "InjectionPoint", a custom type like "Extension".

Both injection points and customization of type "Extension" are new inv17, so this just changes a detail of an unreleased feature.Reported by Robert Haas. Reviewed by Michael Paquier.Discussion:https://postgr.es/m/CA+TgmobfMU5pdXP36D5iAwxV5WKE_vuDLtp_1QyH+H5jMMt21g@mail.gmail.com

1 parent0844b39 commitbb93640Copy full SHA for bb93640

File tree

+215

-131

lines changed

+215

-131

lines changed

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1063,6 +1063,14 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser`
`1063`	`1063`	`See <xref linkend="wait-event-extension-table"/>.`
`1064`	`1064`	`</entry>`
`1065`	`1065`	`</row>`
	`1066`	`+ <row>`
	`1067`	`+ <entry><literal>InjectionPoint</literal></entry>`
	`1068`	`+ <entry>The server process is waiting for an injection point to reach an`
	`1069`	`+ outcome defined in a test. See`
	`1070`	`+ <xref linkend="xfunc-addin-injection-points"/> for more details. This`
	`1071`	`+ type has no predefined wait points.`
	`1072`	`+ </entry>`
	`1073`	`+ </row>`
`1066`	`1074`	`<row>`
`1067`	`1075`	`<entry><literal>IO</literal></entry>`
`1068`	`1076`	`<entry>The server process is waiting for an I/O operation to complete.`
`@@ -1139,8 +1147,8 @@ description \| Waiting for a newly initialized WAL file to reach durable storage`
`1139`	`1147`
`1140`	`1148`	`<note>`
`1141`	`1149`	`<para>`
`1142`		`- Extensions can add <literal>Extension</literal> and`
`1143`		`- <literal>LWLock</literal> events`
	`1150`	`+ Extensions can add <literal>Extension</literal>,`
	`1151`	`+ <literal>InjectionPoint</literal>. and <literal>LWLock</literal> events`
`1144`	`1152`	`to the lists shown in <xref linkend="wait-event-extension-table"/> and`
`1145`	`1153`	`<xref linkend="wait-event-lwlock-table"/>. In some cases, the name`
`1146`	`1154`	`of an <literal>LWLock</literal> assigned by an extension will not be`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3643,7 +3643,11 @@ extern void InjectionPointAttach(const char *name,`
`3643`	`3643`	`static void`
`3644`	`3644`	`custom_injection_callback(const char name, const void private_data)`
`3645`	`3645`	`{`
	`3646`	`+ uint32 wait_event_info = WaitEventInjectionPointNew(name);`
	`3647`	`+`
	`3648`	`+ pgstat_report_wait_start(wait_event_info);`
`3646`	`3649`	`elog(NOTICE, "%s: executed custom callback", name);`
	`3650`	`+ pgstat_report_wait_end();`
`3647`	`3651`	`}`
`3648`	`3652`	`</programlisting>`
`3649`	`3653`	`This callback prints a message to server error log with severity`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ CalculateShmemSize(int *num_semaphores)`
`149`	`149`	`size=add_size(size,SyncScanShmemSize());`
`150`	`150`	`size=add_size(size,AsyncShmemSize());`
`151`	`151`	`size=add_size(size,StatsShmemSize());`
`152`		`-size=add_size(size,WaitEventExtensionShmemSize());`
	`152`	`+size=add_size(size,WaitEventCustomShmemSize());`
`153`	`153`	`size=add_size(size,InjectionPointShmemSize());`
`154`	`154`	`size=add_size(size,SlotSyncShmemSize());`
`155`	`155`	`#ifdefEXEC_BACKEND`
`@@ -355,7 +355,7 @@ CreateOrAttachShmemStructs(void)`
`355`	`355`	`SyncScanShmemInit();`
`356`	`356`	`AsyncShmemInit();`
`357`	`357`	`StatsShmemInit();`
`358`		`-WaitEventExtensionShmemInit();`
	`358`	`+WaitEventCustomShmemInit();`
`359`	`359`	`InjectionPointShmemInit();`
`360`	`360`	`}`
`361`	`361`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -181,9 +181,10 @@`
`181`	`181`	`foreachmy$waitclass (sort {uc($a)cmpuc($b) }keys%hashwe)`
`182`	`182`	`{`
`183`	`183`	`# Don't generate the pgstat_wait_event.c and wait_event_types.h files`
`184`		`-# forExtension, LWLock and Lock, these are handled independently.`
	`184`	`+# fortypes handled independently.`
`185`	`185`	`next`
`186`	`186`	`if ($waitclasseq'WaitEventExtension'`
	`187`	`+\|\|$waitclasseq'WaitEventInjectionPoint'`
`187`	`188`	`\|\|$waitclasseq'WaitEventLWLock'`
`188`	`189`	`\|\|$waitclasseq'WaitEventLock');`
`189`	`190`

Comments

(0)