NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbb60f2c

Amit Kapila

committed

Fix pg_verify_checksums on Windows.

To verify the checksums, we open the file in text mode which doesn't workon Windows as WIN32 treats Control-Z as EOF in files opened in text mode.This leads to "short read of block .." error in some cases.Fix it by opening the files in the binary mode.Author: Amit KapilaReviewed-by: Magnus HaganderBackpatch-through: 11Discussion:https://postgr.es/m/CAA4eK1+LOnzod+h85FGmyjWzXKy-XV1FYwEyP-Tky2WpD5cxwA@mail.gmail.com

1 parent2e39f69 commitbb60f2cCopy full SHA for bb60f2c

File tree

1 file changed

-1

lines changed

src/bin/pg_verify_checksums
- pg_verify_checksums.c

1 file changed

-1

lines changed

`‎src/bin/pg_verify_checksums/pg_verify_checksums.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ scan_file(char *fn, int segmentno)`
`83`	`83`	`intf;`
`84`	`84`	`intblockno;`
`85`	`85`
`86`		`-f=open(fn,0);`
	`86`	`+f=open(fn,O_RDONLY \|PG_BINARY);`
`87`	`87`	`if (f<0)`
`88`	`88`	`{`
`89`	`89`	`fprintf(stderr,_("%s: could not open file \"%s\": %s\n"),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbb60f2c

File tree

1 file changed

1 file changed

`‎src/bin/pg_verify_checksums/pg_verify_checksums.c`

0 commit comments